Uploaded image for project: 'Drools'
  1. Drools
  2. DROOLS-7254

KieModuleModelWrapper: refactor duplicate of ResourceCollector#fromJarFile

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Won't Do
    • Icon: Major Major
    • None
    • None
    • core engine
    • 2024 Week 07-09 (from Feb 12)
    • NEW
    • NEW
    • ---
    • ---

      Because of the way tests are run in quarkus-platform, in some cases it is necessary to be able to read resources from a jar file.

      In particular, when processing kmodule.xml, depending on how a test is run, it may come from the file system or a jar.

      In the case of DRL files (drools Resource objects), they are already handled through the CollectedResource APIs even in the case they are inside a jar. kmodule.xml was not. Because kmodule.xml processing now occurs in drools-model/drools-model-codegen which is not part of the Quarkus extension, there is no dependency on the CollectedResource APIs

      In order to ship all integration tests to Quarkus platform in a timely manner, I have therefore duplicated some code inside of KieModuleModelWrapper (drools-model/drools-model-codegen) to correctly process a kmodule.xml inside a jar.

      Such code should be moved to a shared location and reused.

              mfusco@redhat.com Mario Fusco
              evacchi Edoardo Vacchi
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: