Uploaded image for project: 'Drools'
  1. Drools
  2. DROOLS-5660

DMN code maint. avoid unnecessary cart.prod. test matrix

    XMLWordPrintable

Details

    • Task
    • Resolution: Done
    • Major
    • None
    • None
    • dmn engine
    • None
    • 2020 Week 37-39 (from Sep 7)
    • 3
    • Undefined
    • NEW
    • NEW
    • ---
    • ---

    Description

      During DROOLS-3238 an abstract base test class was introduced in order to test DMN model in a KJAR containing also Drools Model file for Canonical model / executable model.

      The abstract base test class BaseInterpretedVsCompiledTestCanonicalKieModule was introduced with a first PR:

      https://github.com/kiegroup/drools/pull/2141/files#diff-08550863868c89e6f8ccbbc24fc7cfbaR33

      However as noted in the second PR related to DROOLS-3238,

      Please note that these tests don't actually verify the correct behaviour of the compiled DRL files, but they only verify the DMN model.

      ref:

      https://github.com/kiegroup/drools/pull/2460#issue-298982811

      This inadvertently later resulted in a cartesian product matrix configuration inflation, while a single specific test would have sufficed: most of the tests which has been extended with BaseInterpretedVsCompiledTestCanonicalKieModule actually test behaviour of KieContainer on kie-server normally produced by WB/BC artifacts, which not being maven-based hardly can replicate a Canonical model / executable model artifact.

      Attachments

        Issue Links

          Activity

            People

              mmortari@redhat.com Matteo Mortari
              mmortari@redhat.com Matteo Mortari
              Daniel Rosa Daniel Rosa
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: