Uploaded image for project: 'Drools'
  1. Drools
  2. DROOLS-5324

Refactor "if" driven compilation for dmn/pmml

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Done
    • Icon: Major Major
    • None
    • None
    • None
    • None
    • 2020 Week 22-24 (from May 25)
    • NEW
    • NEW

      Inside

       CanonicalKieModule.createKieBase( KieBaseModelImpl, KieProject, ResultsImpl, KieBaseConfiguration)
      

      there is a call to

       CanonicalKieModule.hasNonModelResources( KieBaseModelImpl, KieProject )
      

      This method returns `true` if there are some dmn and/or pmml files in the project.
      If such boolean is `true` a new KnowledgePackagesBuildResult is created.
      The main issues with this approach are:
      1) managing of dmn/pmml resources is completely hidden inside this boolean method and hard to find in debug
      2) it is possible that the new KnowledgePackagesBuildResult build will fire a compilation also of "drl" or other resources that are "compiled" anyway even without this flag

            mfusco@redhat.com Mario Fusco
            gcardosi Gabriele Cardosi (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: