Uploaded image for project: 'Drools'
  1. Drools
  2. DROOLS-5060

[DMN Designer] Editor allows node with prefix/trailing space

    XMLWordPrintable

Details

    Description

      I understand DROOLS-5017 has been re-purposed to allow Info and Warn level messages be displayed on Stunner Validation dialog. That is fine.

      But, imho, an UX point is not being considered, where is necessary instead.

      By the DMN spec, a node should not have a prefix/trailing space, as space insensitivity would mandate 1 trailing or 2 trailing spaces are simply ignored etc.
      The engine is lenient to avoid this crashing the evaluation, but still is a bad designed model to persist the node name (DRGElement name and its corresponding variable name) with those extra spaces IMHO.

      Further, I consider is just the Analyst which slipped a space.

      In my perspective, the editor should just strip away the prefix/trailing space:

      • While Importing a DMN model from file Upload (See DROOLS-5062)
      • While editing a DRGElement and hitting OK to save its name

      For your consideration, thanks.

      Manual acceptance test

      • Rename a node, check undo/redo
      • Leading space
      • Trailing space
      • Save and reopen
      • Documentation tab
      • Rename via node popup
      • Rename via properties panel
      • Rename via expression grid - where applicable

      Attachments

        Issue Links

          causes

          Bug - A problem that impairs or prevents the functions of the product. DROOLS-5137 [DMN Designer] Decision Navigator shows Name.toString() value for diagram

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed
          incorporates

          Bug - A problem that impairs or prevents the functions of the product. RHDM-1247 [DMN Designer] properties panel is not refreshed for top level output header

          • Minor - To be worked after urgent, high, and medium priorities are resolved. This term is chosen when the severity of the issue is low, or the complexity or effort to correct it may be higher, relatively speaking. For low priority issues, known workarounds exist or are not needed due to the trivial effort needed to address the issue.
          • Closed
          is cloned by

          Bug - A problem that impairs or prevents the functions of the product. DROOLS-5062 [DMN Designer] Systematically correct node prefix/trailing space on import

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Open
          is related to

          Enhancement - An enhancement to or refactoring of existing functionality that is not configurable by an end user (typically a change made by an internal team that affects users) DROOLS-3648 [DMN Designer] Boxed expressions - Decision Table - Allow Literal Expressions in the Decision Table header

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed
          relates to

          Bug - A problem that impairs or prevents the functions of the product. DROOLS-5017 [DMN Designer] Validation issues are not shown in Alerts panel

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Activity

            People

              manstis@redhat.com Michael Anstis
              mmortari@redhat.com Matteo Mortari
              Jozef Marko Jozef Marko
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: