Uploaded image for project: 'Drools'
  1. Drools
  2. DROOLS-4724

[DMN Designer] Do not default to a LiteralExpression when no expression is defined

    Details

    • Sprint:
      2019 Week 47-49 (from Nov 18), 2019 Week 50-52 (from Dec 9)
    • Story Points:
      1
    • Docs QE Status:
      NEW
    • QE Status:
      NEW

      Description

      Currently, the DMN Editor will default to a blank LiteralExpression on Save if the user did not provide an expression for an element.
      However Error message is reported anyway to the user:

      This also as the (imho undesired) side-effect that if the user was to re-open later that file, instead of a empty element, it would be a blank LiteralExpression

      so the current behavior is not consistent across re-open of the editor.

      Let's revert this default.

      The DMN Editor on save should not default to a blank LiteralExpression if the user did not provide an expression for the element.
      Once this change is applied from the f/e side, I am happy to be involved in order to assess which of the messages reported by the Validator or the Compiler are causing issue to the WB (if any).
      Currently, the DMN Compiler will throw 1 Warning.
      Currently, the DMN Validator will throw 1 Error (I can align this to be a Warn too).
      Currently, the DMN Validator schema check is not reporting any XSD violation.

      Manual acceptance test

      Try to save default / empty

      Business Central

      • Decision node
      • BKM node
      • Cleared Function
      • Context entry
      • Invocation

      Kogito

      • Decision node
      • BKM node
      • Cleared Function
      • Context entry
      • Invocation

        Gliffy Diagrams

          Attachments

          1. error.log
            33 kB
          2. image-2019-11-04-19-39-01-113.png
            image-2019-11-04-19-39-01-113.png
            103 kB
          3. image-2019-11-04-19-40-27-201.png
            image-2019-11-04-19-40-27-201.png
            84 kB
          4. m.dmn
            2 kB
          5. save-context.webm
            2.73 MB
          6. screenshot-1.png
            screenshot-1.png
            78 kB
          7. screenshot-2.png
            screenshot-2.png
            77 kB
          8. Screenshot from 2019-11-29 12-04-18.png
            Screenshot from 2019-11-29 12-04-18.png
            235 kB

            Issue Links

              Activity

                People

                • Assignee:
                  manstis Michael Anstis
                  Reporter:
                  tari_manga Matteo Mortari
                  Tester:
                  Jozef Marko
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: