Uploaded image for project: 'Drools'
  1. Drools
  2. DROOLS-355

Add an import on com.sun.tools.xjc in drools-core's OSGI manifest

    XMLWordPrintable

Details

    • Task
    • Status: Resolved (View Workflow)
    • Blocker
    • Resolution: Done
    • 6.0.0.Final
    • 7.0.0.Beta3
    • None
    • None

    Description

      By importing com.sun.tools.xjc, 3 problems arise:

      • OSGi and Karaf trip over it.
        [WARNING] No export found to match com.sun.tools.xjc (imported by mvn:org.drools/drools-core/6.0.0.Final)
        
      • JDK 9 will break any java app that uses com.sun.* classes. See Mark Reinhold's Jigsaw presentation at devoxxBE 2013. But XJC is an exception because it's not part of the JDK, it's a separate jar?
      • IBM JDK's etc don't have com.sun.* classes. Why don't they trip over this?

      Why do we have those imports in the first place? Looks like code for old JAXB code - which is hopefully stale now.

      Where do we use it?

      Targets
          String 'com.sun.tools.xjc'
      Found usages  (38 usages found)
          drools-compiler  (7 usages found)
              /home/gdesmet/projects/jboss/droolsjbpm/drools/drools-compiler  (1 usage found)
                  pom.xml  (1 usage found)
                      (246: 15) com.sun.tools.xjc.*;resolution:=optional,
              org.drools.compiler.builder.impl  (1 usage found)
                  KnowledgeBuilderFactoryServiceImpl.java  (1 usage found)
                      (18: 8) import com.sun.tools.xjc.Options;
              org.drools.compiler.runtime.pipeline.impl  (5 usages found)
                  DroolsJaxbHelperProviderImpl.java  (5 usages found)
                      (77: 8) import com.sun.tools.xjc.BadCommandLineException;
                      (78: 8) import com.sun.tools.xjc.ErrorReceiver;
                      (79: 8) import com.sun.tools.xjc.ModelLoader;
                      (80: 8) import com.sun.tools.xjc.Options;
                      (81: 8) import com.sun.tools.xjc.model.Model;
          drools-core  (2 usages found)
              org.drools.core.builder.conf.impl  (2 usages found)
                  JaxbConfigurationImpl.java  (2 usages found)
                      (28: 8) import com.sun.tools.xjc.Language;
                      (34: 8) import com.sun.tools.xjc.Options;
          kie-internal  (6 usages found)
              /home/gdesmet/projects/jboss/droolsjbpm/droolsjbpm-knowledge/kie-internal  (1 usage found)
                  pom.xml  (1 usage found)
                      (27: 15) com.sun.tools.xjc;resolution:=optional,
              org.kie.internal.builder  (3 usages found)
                  JaxbConfiguration.java  (1 usage found)
                      (23: 8) import com.sun.tools.xjc.Options;
                  KnowledgeBuilderFactory.java  (1 usage found)
                      (24: 8) import com.sun.tools.xjc.Options;
                  KnowledgeBuilderFactoryService.java  (1 usage found)
                      (24: 8) import com.sun.tools.xjc.Options;
              org.kie.internal.builder.help  (2 usages found)
                  DroolsJaxbHelperProvider.java  (1 usage found)
                      (29: 8) import com.sun.tools.xjc.Options;
                  KnowledgeBuilderHelper.java  (1 usage found)
                      (30: 8) import com.sun.tools.xjc.Options;
          knowledge-api  (8 usages found)
              org.drools.builder  (3 usages found)
                  JaxbConfiguration.java  (1 usage found)
                      (21: 8) import com.sun.tools.xjc.Options;
                  KnowledgeBuilderFactory.java  (1 usage found)
                      (24: 8) import com.sun.tools.xjc.Options;
                  KnowledgeBuilderFactoryService.java  (1 usage found)
                      (24: 8) import com.sun.tools.xjc.Options;
              org.drools.builder.help  (3 usages found)
                  DroolsJaxbHelperProvider.java  (1 usage found)
                      (29: 8) import com.sun.tools.xjc.Options;
                  KnowledgeBuilderHelper.java  (2 usages found)
                      (32: 8) import com.sun.tools.xjc.Language;
                      (33: 8) import com.sun.tools.xjc.Options;
              org.drools.impl  (1 usage found)
                  KnowledgeBuilderFactoryServiceImpl.java  (1 usage found)
                      (16: 8) import com.sun.tools.xjc.Options;
              org.drools.impl.adapters  (1 usage found)
                  JaxbConfigurationAdapter.java  (1 usage found)
                      (3: 8) import com.sun.tools.xjc.Options;
      
      

      Attachments

        Issue Links

          Activity

            People

              mfusco@redhat.com Mario Fusco
              gdesmet@redhat.com Geoffrey De Smet
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: