Uploaded image for project: 'Data Foundation Bugs'
  1. Data Foundation Bugs
  2. DFBUGS-1261

ControllerGetVolumeGroup, DeleteVolumeGroup and DeleteVolumeGroupSnapshot RPCs are not idempotent

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done-Errata
    • Icon: Undefined Undefined
    • odf-4.18
    • odf-4.18
    • csi-driver
    • False
    • False
    • Committed
    • ?
    • ?
    • 4.18.0-132
    • Committed
    • Release Note Not Required
    • None

      Description of problem -

      Ideally, ControllerGetVolumeGroup and DeleteVolumeGroup should be idempotent i.e, if the volume group is not found in the backend then the ControllerVolumeGroup shall return status code as NotFound and if the volume group has been already deleted from the backend then the DeleteVolumeGroup shall return the response as OK. But, either of them is not the case now.

      The ControllerVolumeGroup RPC call returns OK response with the volume group id , even if the volume group doesn't exists. And, the DeleteVolumeGroup RPC call returns BUG: name not set error while trying to delete an already deleted volume group.

       

      Is there any workaround available to the best of your knowledge?

      No

       

      Can this issue be reproduced? If so, please provide the hit rate

      Yes

       

      Can this issue be reproduced from the UI?

      If this is a regression, please provide more details to justify this:

      Steps to Reproduce:

      1. Use the csi-addons cli and try to fetch an non-existing volume group

      2. Use the csi-addons cli and try to delete an already deleted volume group

       

      Actual results:

      1. A non-existent volume group is returned with an OK reponse.

      2. An already deleted volume group fails with an error.

       

      Expected results:

      1. A non-existent volume group should return a NotFound status code.

      2. An already deleted volume group should return an OK response.

       

              nladha Nikhil Ladha
              nladha Nikhil Ladha
              Sidhant Agrawal Sidhant Agrawal
              Votes:
              0 Vote for this issue
              Watchers:
              20 Start watching this issue

                Created:
                Updated:
                Resolved: