Uploaded image for project: 'Debezium'
  1. Debezium
  2. DBZ-3218

Handle duplicate warnings for deprecated options

    XMLWordPrintable

Details

    Description

      1. The getFallbackStringProperty() method is producing the warnings when we validate any include/exclude option. It triggers the first warning there i.e. when initially config options are defined.
      Then there are several other places where we call the same method; for instance, when you create Filters here and then while defining new tables here etc.
      So each time that method is called that would trigger the warning, which piles up to repeated warnings.

      2. Also, we have added validation to all include/exclude and blacklist/whitelist property.
      Consider a case where all the four options are mentioned like COLUMN_INCLUDE_LIST, COLUMN_EXCLUDE_LIST, COLUMN_WHITELIST, COLUMN_BLACKLIST when these are provided the validateColumnExcludeList method gets executed four times (that logs x2 warnings ie 8). That's too many again.

      private static int validateColumnExcludeList(Configuration config, Field field, Field.ValidationOutput problems) {
              String includeList = Configuration.getFallbackStringProperty(config, COLUMN_INCLUDE_LIST, COLUMN_WHITELIST);
              String excludeList = Configuration.getFallbackStringProperty(config, COLUMN_EXCLUDE_LIST, COLUMN_BLACKLIST);
               ...
      }
      

      Attachments

        Issue Links

          Activity

            People

              anmohant Anisha Mohanty
              anmohant Anisha Mohanty
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: