Uploaded image for project: 'Debezium'
  1. Debezium
  2. DBZ-202

Fix daylight savings related test failures

    XMLWordPrintable

Details

    Description

      I was getting these errors ever since DST:

      Tests run: 4, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 1.207 sec <<< FAILURE! - in io.debezium.connector.mysql.MySqlConnectorRegressionIT
      shouldConsumeAllEventsFromDatabaseUsingBinlogAndNoSnapshot(io.debezium.connector.mysql.MySqlConnectorRegressionIT)  Time elapsed: 0.992 sec  <<< FAILURE!
      org.junit.ComparisonFailure: expected:<[0]> but was:<[1]>
      	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
      	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
      	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
      	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
      	at org.fest.assertions.ConstructorInvoker.newInstance(ConstructorInvoker.java:36)
      	at org.fest.assertions.ComparisonFailureFactory.newComparisonFailure(ComparisonFailureFactory.java:60)
      	at org.fest.assertions.ComparisonFailureFactory.comparisonFailure(ComparisonFailureFactory.java:46)
      	at org.fest.assertions.Fail.comparisonFailed(Fail.java:83)
      	at org.fest.assertions.Fail.failIfNotEqual(Fail.java:71)
      	at org.fest.assertions.GenericAssert.isEqualTo(GenericAssert.java:217)
      	at org.fest.assertions.IntAssert.isEqualTo(IntAssert.java:61)
      	at io.debezium.connector.mysql.MySqlConnectorRegressionIT.lambda$shouldConsumeAllEventsFromDatabaseUsingBinlogAndNoSnapshot$0(MySqlConnectorRegressionIT.java:228)
      
      shouldConsumeAllEventsFromDatabaseUsingBinlogAndNoSnapshotAndConnectTimesTypes(io.debezium.connector.mysql.MySqlConnectorRegressionIT)  Time elapsed: 0.002 sec  <<< FAILURE!
      org.junit.ComparisonFailure: expected:<[0]> but was:<[1]>
      	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
      	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
      	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
      	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
      	at org.fest.assertions.ConstructorInvoker.newInstance(ConstructorInvoker.java:36)
      	at org.fest.assertions.ComparisonFailureFactory.newComparisonFailure(ComparisonFailureFactory.java:60)
      	at org.fest.assertions.ComparisonFailureFactory.comparisonFailure(ComparisonFailureFactory.java:46)
      	at org.fest.assertions.Fail.comparisonFailed(Fail.java:83)
      	at org.fest.assertions.Fail.failIfNotEqual(Fail.java:71)
      	at org.fest.assertions.GenericAssert.isEqualTo(GenericAssert.java:217)
      	at org.fest.assertions.IntAssert.isEqualTo(IntAssert.java:61)
      	at io.debezium.connector.mysql.MySqlConnectorRegressionIT.lambda$shouldConsumeAllEventsFromDatabaseUsingBinlogAndNoSnapshotAndConnectTimesTypes$1(MySqlConnectorRegressionIT.java:436)
      
      Running io.debezium.connector.mysql.MySqlTaskContextIT
      Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in io.debezium.connector.mysql.MySqlTaskContextIT
      Running io.debezium.connector.mysql.ReadBinLogIT
      Mar 14, 2017 12:11:12 PM com.github.shyiko.mysql.binlog.BinaryLogClient connect
      INFO: Connected to localhost:3306 at mysql-bin.000003/5616 (sid:65534, cid:74)
      Mar 14, 2017 12:11:13 PM com.github.shyiko.mysql.binlog.BinaryLogClient connect
      INFO: Connected to localhost:3306 at mysql-bin.000003/8104 (sid:65534, cid:77)
      Mar 14, 2017 12:11:14 PM com.github.shyiko.mysql.binlog.BinaryLogClient connect
      INFO: Connected to localhost:3306 at mysql-bin.000003/9646 (sid:65534, cid:79)
      Tests run: 7, Failures: 0, Errors: 0, Skipped: 3, Time elapsed: 2.036 sec - in io.debezium.connector.mysql.ReadBinLogIT
      Running io.debezium.connector.mysql.SnapshotReaderIT
      Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.698 sec - in io.debezium.connector.mysql.SnapshotReaderIT
      
      Results :
      
      Failed tests:
        MySqlConnectorRegressionIT.shouldConsumeAllEventsFromDatabaseUsingBinlogAndNoSnapshot:119->lambda$shouldConsumeAllEventsFromDatabaseUsingBinlogAndNoSnapshot$0:228 expected:<[0]> but was:<[1]>
        MySqlConnectorRegressionIT.shouldConsumeAllEventsFromDatabaseUsingBinlogAndNoSnapshotAndConnectTimesTypes:326->lambda$shouldConsumeAllEventsFromDatabaseUsingBinlogAndNoSnapshotAndConnectTimesTypes$1:436 expected:<[0]> but was:<[1]>
      
      Tests run: 41, Failures: 2, Errors: 0, Skipped: 5
      

      Looks like there's already precedent in the code for fixing these issues: https://github.com/debezium/debezium/blob/031c4a15524c1de72510d60d64c87aa344435599/debezium-connector-mysql/src/test/java/io/debezium/connector/mysql/MySqlConnectorRegressionIT.java#L604

      Attachments

        Activity

          People

            dasl_jira David Leibovic (Inactive)
            dasl_jira David Leibovic (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: