• Type: Enhancement
• Resolution: Done
• Priority: Major
• Fix Version/s: 1.0.0.Beta2
• Affects Version/s: None
• Component/s: postgresql-connector
• Labels:

  None

[DBZ-1525] Validate configured replication slot names

Collapse comment: Jiri Pechanec added a comment - 2019/10/20 11:26 PM

Jiri Pechanec added a comment - 2019/10/20 11:26 PM

Well, yes the test and the behaviour was working correctly. Unfortunately the connector got into a bad state before the cleanup code was executed so it is reasonable to do both the validation and the cleanup after using incorrect slot name. Technically this issue shoudl ensure that the other originila one is not triggered but better safe than sorry .

Expand comment: Jiri Pechanec added a comment - 2019/10/20 11:26 PM

Jiri Pechanec added a comment - 2019/10/20 11:26 PM Well, yes the test and the behaviour was working correctly. Unfortunately the connector got into a bad state before the cleanup code was executed so it is reasonable to do both the validation and the cleanup after using incorrect slot name. Technically this issue shoudl ensure that the other originila one is not triggered but better safe than sorry .

Collapse comment: Gunnar Morling added a comment - 2019/10/20 4:17 PM

Gunnar Morling added a comment - 2019/10/20 4:17 PM

jpechane, about your question above – is it resolved?

Expand comment: Gunnar Morling added a comment - 2019/10/20 4:17 PM

Gunnar Morling added a comment - 2019/10/20 4:17 PM jpechane , about your question above – is it resolved?

Collapse comment: Jiri Pechanec added a comment - 2019/10/07 5:03 AM

Jiri Pechanec added a comment - 2019/10/07 5:03 AM

We have a test for it io.debezium.connector.postgresql.connection.ReplicationConnectionIT.shouldCloseConnectionOnInvalidSlotName(). Is it broken then?

Expand comment: Jiri Pechanec added a comment - 2019/10/07 5:03 AM

Jiri Pechanec added a comment - 2019/10/07 5:03 AM We have a test for it io.debezium.connector.postgresql.connection.ReplicationConnectionIT.shouldCloseConnectionOnInvalidSlotName() . Is it broken then?