Uploaded image for project: 'Red Hat OpenShift Dev Spaces (formerly CodeReady Workspaces) '
  1. Red Hat OpenShift Dev Spaces (formerly CodeReady Workspaces)
  2. CRW-4158

[RN] To start VS Code, use `post-start` rather than overriding the entrypoint

XMLWordPrintable

    • False
    • None
    • False
    • Release Notes
    • The release note is documented in https://issues.redhat.com/browse/CRW-4194.
    • Rejected

      Synced from eclipse/che issue

      https://github.com/eclipse/che/issues/21879

      Is your enhancement related to a problem? Please describe

      VS Code che-code-runtime-description component contributes the container command to the tooling container:

      (...)
        - schemaVersion: 2.1.0
          metadata: 
            name: che-incubator/che-code/insiders
          (...)
          components: 
            - name: che-code-runtime-description
              attributes: 
                controller.devfile.io/container-contribution: true 
              container: 
                (...)
                command: 
                  - /checode/entrypoint-volume.sh
      

      As a result, the script /checode/entrypoint-volume.sh is executed at workspace startup, but the tooling container entrypoint (for example UDI's) is not.

      This is problematic as the tooling container entrypoint may be used to initialise development tools and runtimes.

      Describe the solution you'd like

      We should use a post-start event rather than the command to start VS Code.

      That should be tested though and may require some tweaks to the VS Code startup script (or not).

      This is currently VS Code specific but will JetBrains and Theia may be affected too if this feature is implemented in the meantime.

              rhn-ecs-pkovar Petr Kovar (Inactive)
              jiralint.codeready Bot Codeready
              Maksym Musienko Maksym Musienko
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: