Uploaded image for project: 'Red Hat OpenShift Dev Spaces (formerly CodeReady Workspaces) '
  1. Red Hat OpenShift Dev Spaces (formerly CodeReady Workspaces)
  2. CRW-3853

Allow to configure subdomain isolation for GitHub Enterprise Server in CheCluster CR

    XMLWordPrintable

Details

    • Task
    • Resolution: Duplicate
    • Major
    • 3.3.0.GA
    • 3.3.0.GA
    • docs
    • False
    • None
    • False
    • Hide
      = Allow to configure subdomain isolation for GitHub Enterprise Server in CheCluster CR

      In GitHub Enterprise Server subdomains can be [isolated](https://docs.github.com/en/enterprise-server@3.5/admin/configuration/configuring-network-settings/enabling-subdomain-isolation) (as it's the case for `github.com`) and it's now supported by Eclipse Che.
      Show
      = Allow to configure subdomain isolation for GitHub Enterprise Server in CheCluster CR In GitHub Enterprise Server subdomains can be [isolated]( https://docs.github.com/en/enterprise-server@3.5/admin/configuration/configuring-network-settings/enabling-subdomain-isolation ) (as it's the case for `github.com`) and it's now supported by Eclipse Che.
    • Rejected

    Description

      Synced from eclipse/che issue

      https://github.com/eclipse/che/issues/21724

      Is your enhancement related to a problem? Please describe

      GitHub Enterprise Server customers have the option to enable/disable subdomain isolation. URLs to GitHub resources depend on this configuration:

      <table>
      <tr>
      <td>Path without subdomain isolation
      <td>Path with subdomain isolation
      <tr>
      <td>`http(s)://HOSTNAME/raw/`
      <td>`http(s)://raw.HOSTNAME/`
      </table>

      Describe the solution you'd like

      A Dev Spaces admin should be able to specify if subdomain-isolated is enabled or not in CheCluster CR:

      spec: 
        gitServices: 
          github: 
            - endpoint: 'https://github.com'
              secretName: github-oauth-config
              disableSubdomainIsolation: true 
      

      And Che server should use paths with or without subdomain isolation, when resolving GitHub files, based on that configuration.

      Note: GitHub suggest to enable subdomain-isolation so when not specified we assume that disableSubdomainIsolation: false (that's also the github.com config anyway)

      Release Notes Text

      In GitHub Enterprise Server subdomains can be isolated (as it's the case for github.com) and it's now supported by Eclipse Che.

      Attachments

        Activity

          People

            rhn-ecs-pkovar Petr Kovar (Inactive)
            nickboldt Nick Boldt
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: