Uploaded image for project: 'Red Hat OpenShift Dev Spaces (formerly CodeReady Workspaces) '
  1. Red Hat OpenShift Dev Spaces (formerly CodeReady Workspaces)
  2. CRW-3331

INTERNAL_URL variables not replaced at runtime for code editor yamls

    XMLWordPrintable

Details

    • False
    • None
    • False

    Description

      In entrypoint.sh for DS 3.2 and 3.3, we do this to replace placeholder/variable INTERNAL_URL with the actual URL in devworkspace-che-theia-latest.yaml, eg., http://devfile-registry.openshift-devspaces.svc:8080

      But we don't do the same transform for devworkspace-che-code-insiders.yaml resulting in URLs that can't be loaded.

      sh-4.4$ grep -R "location:" | grep svc
      00_java11-maven-eap/devworkspace-che-theia-latest.yaml:          location: 'http://devfile-registry.openshift-devspaces.svc:8080/resources/v2/jboss-eap-quickstarts.zip'
      00_java11-maven-microprofile-xp3/devworkspace-che-theia-latest.yaml:          location: 'http://devfile-registry.openshift-devspaces.svc:8080/resources/v2/microprofile-quickstart.zip'
      03_camelk/devworkspace-che-theia-latest.yaml:          location: 'http://devfile-registry.openshift-devspaces.svc:8080/resources/v2/camel-k.zip'
      03_java11-maven-gradle/devworkspace-che-theia-latest.yaml:          location: 'http://devfile-registry.openshift-devspaces.svc:8080/resources/v2/gs-validating-form-input.zip'
      03_java11-maven-lombok/devworkspace-che-theia-latest.yaml:          location: 'http://devfile-registry.openshift-devspaces.svc:8080/resources/v2/lombok-project-sample.zip'
      03_java11-maven-quarkus/devworkspace-che-theia-latest.yaml:          location: 'http://devfile-registry.openshift-devspaces.svc:8080/resources/v2/quarkus-quickstarts.zip'
      04_nodejs-mongo/devworkspace-che-theia-latest.yaml:          location: 'http://devfile-registry.openshift-devspaces.svc:8080/resources/v2/nodejs-mongodb-sample.zip'
      04_nodejs-simple/devworkspace-che-theia-latest.yaml:          location: 'http://devfile-registry.openshift-devspaces.svc:8080/resources/v2/web-nodejs-sample.zip'
      04_python/devworkspace-che-theia-latest.yaml:          location: 'http://devfile-registry.openshift-devspaces.svc:8080/resources/v2/python-hello-world.zip'
      05_cpp/devworkspace-che-theia-latest.yaml:          location: 'http://devfile-registry.openshift-devspaces.svc:8080/resources/v2/c-plus-plus.zip'
      05_go/devworkspace-che-theia-latest.yaml:          location: 'http://devfile-registry.openshift-devspaces.svc:8080/resources/v2/golang-health-check.zip'
      05_php-cake/devworkspace-che-theia-latest.yaml:          location: 'http://devfile-registry.openshift-devspaces.svc:8080/resources/v2/cakephp-ex.zip'
      05_php-di/devworkspace-che-theia-latest.yaml:          location: 'http://devfile-registry.openshift-devspaces.svc:8080/resources/v2/demo.zip'

      vs.

      sh-4.4$ grep -R "{{" 
      00_java11-maven-eap/devworkspace-che-code-insiders.yaml:          location: '{{INTERNAL_URL}}/resources/v2/jboss-eap-quickstarts.zip'
      00_java11-maven-microprofile-xp3/devworkspace-che-code-insiders.yaml:          location: '{{INTERNAL_URL}}/resources/v2/microprofile-quickstart.zip'
      03_camelk/devworkspace-che-code-insiders.yaml:          location: '{{INTERNAL_URL}}/resources/v2/camel-k.zip'
      03_java11-maven-gradle/devworkspace-che-code-insiders.yaml:          location: '{{INTERNAL_URL}}/resources/v2/gs-validating-form-input.zip'
      03_java11-maven-lombok/devworkspace-che-code-insiders.yaml:          location: '{{INTERNAL_URL}}/resources/v2/lombok-project-sample.zip'
      03_java11-maven-quarkus/devworkspace-che-code-insiders.yaml:          location: '{{INTERNAL_URL}}/resources/v2/quarkus-quickstarts.zip'
      04_nodejs-mongo/devworkspace-che-code-insiders.yaml:          location: '{{INTERNAL_URL}}/resources/v2/nodejs-mongodb-sample.zip'
      04_nodejs-simple/devworkspace-che-code-insiders.yaml:          location: '{{INTERNAL_URL}}/resources/v2/web-nodejs-sample.zip'
      04_python/devworkspace-che-code-insiders.yaml:          location: '{{INTERNAL_URL}}/resources/v2/python-hello-world.zip'
      05_cpp/devworkspace-che-code-insiders.yaml:          location: '{{INTERNAL_URL}}/resources/v2/c-plus-plus.zip'
      05_go/devworkspace-che-code-insiders.yaml:          location: '{{INTERNAL_URL}}/resources/v2/golang-health-check.zip'
      05_php-cake/devworkspace-che-code-insiders.yaml:          location: '{{INTERNAL_URL}}/resources/v2/cakephp-ex.zip'
      05_php-di/devworkspace-che-code-insiders.yaml:          location: '{{INTERNAL_URL}}/resources/v2/demo.zip'

      Attachments

        Activity

          People

            vsvydenk Valerii Svydenko
            nickboldt Nick Boldt
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: