-
Bug
-
Resolution: Obsolete
-
Major
-
3.0.0.GA
-
None
-
3
-
False
-
False
-
-
Prod #216 2022-03-16
The rhpkg source files are generated artifacts created when you run `rhpkg new-sources` (from get-sources.sh scripts):
$➔ grep "rhpkg new" */get-sources.sh codeready-workspaces-configbump/get-sources.sh: rhpkg new-sources ${theTarGzs} codeready-workspaces-dashboard/get-sources.sh: rhpkg new-sources ${outputFiles} codeready-workspaces-devfileregistry/get-sources.sh: rhpkg new-sources ${TARGZs} codeready-workspaces/get-sources.sh: rhpkg new-sources ${outputFile} codeready-workspaces-idea/get-sources.sh: rhpkg new-sources ${outputFiles} codeready-workspaces-imagepuller/get-sources.sh: rhpkg new-sources ${TARGZs} codeready-workspaces-operator/get-sources.sh: rhpkg new-sources asset-devworkspace-operator.zip asset-header-rewrite-traefik-plugin.zip codeready-workspaces-plugin-java11/get-sources.sh: rhpkg new-sources ${outputFiles} codeready-workspaces-plugin-java11-openj9/get-sources.sh: rhpkg new-sources ${outputFiles} codeready-workspaces-plugin-java8/get-sources.sh: rhpkg new-sources ${outputFiles} codeready-workspaces-plugin-java8-openj9/get-sources.sh: rhpkg new-sources ${outputFiles} codeready-workspaces-plugin-kubernetes/get-sources.sh: rhpkg new-sources ${outputFiles} codeready-workspaces-plugin-openshift/get-sources.sh: rhpkg new-sources bin.tgz codeready-workspaces-pluginregistry/get-sources.sh: rhpkg new-sources ${TARGZs} codeready-workspaces-stacks-golang/get-sources.sh: rhpkg new-sources ${theTarGzs} codeready-workspaces-stacks-php/get-sources.sh: rhpkg new-sources ${theTarGzs} codeready-workspaces-traefik/get-sources.sh: rhpkg new-sources ${theTarGzs} codeready-workspaces-udi/get-sources.sh: rhpkg new-sources ${outputFiles}
But as discovered recently, if you use changes to midstream as input to triggering midstream builds, you get into a perpetual build loop. So to avoid this, we have:
https://gitlab.cee.redhat.com/codeready-workspaces/crw-jenkins/-/merge_requests/1095/diffs
But the question remains – why do we need these sources files in the midstream repo, if they are generated only for use with pkgs.devel repos? Are they useful, and are they up to date compared to the generated ones downstream?
If not, then we should add them to .gitignore and avoid committing them / copying them to downstream.