Uploaded image for project: 'Red Hat OpenShift Dev Spaces (formerly CodeReady Workspaces) '
  1. Red Hat OpenShift Dev Spaces (formerly CodeReady Workspaces)
  2. CRW-2528

remove node 10 lang server from java8 sidecars

    XMLWordPrintable

Details

    • 1
    • False
    • False
    • Hide
      = Node.js 10 language server is removed from the Node sidecar

      This update removes the Node.js 10 language server from the link:https://github.com/redhat-developer/codeready-workspaces-images/tree/crw-2-rhel-8/codeready-workspaces-plugin-java8[Node sidecar], as the sidecar currently supports Node.js 12.
      Show
      = Node.js 10 language server is removed from the Node sidecar This update removes the Node.js 10 language server from the link: https://github.com/redhat-developer/codeready-workspaces-images/tree/crw-2-rhel-8/codeready-workspaces-plugin-java8 [Node sidecar], as the sidecar currently supports Node.js 12.

    Description

      Currently, CRW 2.13 includes typescript lang server 0.3.7 - https://github.com/redhat-developer/codeready-workspaces-images/blob/crw-2-rhel-8/codeready-workspaces-plugin-java8/build/build_node10.sh#L19
      Latest is 0.8.1 - https://github.com/typescript-language-server/typescript-language-server/releases/tag/v0.8.1

      We're on typescript 3.4.5: https://github.com/redhat-developer/codeready-workspaces-images/blob/crw-2-rhel-8/codeready-workspaces-plugin-java8/build/build_node10.sh#L18
      Latest is 4.5.2: https://www.npmjs.com/package/typescript

      So I asked...

      Nick: why are we still providing node 10 based lang server in CRW? https://github.com/eclipse-che/che-devfile-registry/pull/529#issuecomment-984098394 Could we move to latest for Node 14 or 16?
      Valerii: i think it's just because we haven't try to upgrade it, at least i don't see any problem with that, but we have to test new node version with all samples which use this image.
      Also i think we can drop typescript and typescript-language-server https://github.com/redhat-developer/codeready-workspaces-images/blob/crw-2-rhel-8/codeready-workspaces-plugin-java8/build/build_node10.sh#L63 i don't see that we install them in upstream. @fbenoit wdyt?
      Florent: yes we don't need it

      So... we can remove the outdated lang server entirely.

      Attachments

        Issue Links

          Activity

            People

              vsvydenk Valerii Svydenko
              nickboldt Nick Boldt
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: