Uploaded image for project: 'Red Hat OpenShift Dev Spaces (formerly CodeReady Workspaces) '
  1. Red Hat OpenShift Dev Spaces (formerly CodeReady Workspaces)
  2. CRW-2146

operator-metadata sync - don't push commit when only change is timestamp in a CSV file

XMLWordPrintable

    • False
    • False
    • Undefined

      With the new sync logic in CRW-1846 that uses the standard sync.sh and get-sources.sh scripts common to other builds, a problem has occurred in that we are committing lots of "nuissance commits" to the repo every time we regenerate the CSV and nothing but the timestamp has changed.

      https://github.com/redhat-developer/codeready-workspaces-images/commit/63bef59326d520cd85b1828d279a63c6b96ee4c4

      Solution is to check if the proposed commit includes a diff that is more than just a one-line timestamp change, and if so, undo the proposed change and don't commit the dirty workspace.

      Similar code exists here, which can be ported over to the sync.sh script to avoid these needless updates.

      https://github.com/redhat-developer/codeready-workspaces-images/blob/crw-2.11-rhel-8/crw-jenkins/jobs/CRW_CI/crw-operator-metadata_2.x.jenkinsfile#L98-L102

              mkuznets Mykhailo Kuznietsov
              nickboldt Nick Boldt
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Created:
                Updated:
                Resolved: