Uploaded image for project: 'Red Hat OpenShift Dev Spaces (formerly CodeReady Workspaces) '
  1. Red Hat OpenShift Dev Spaces (formerly CodeReady Workspaces)
  2. CRW-1794

yarn 2 vendoring introduces large binaries which are not readily allowed in pkgs.devel

    XMLWordPrintable

Details

    • False
    • False
    • Undefined

    Description

      I've manually copied all the synced code from che-dashboard 7.30.x to codeready-workspaces-images/codeready-workspaces-dashboard 2.x into pkgs.devel/codeready-workspaces-dashboard 2.8 too, but dist-git won't allow large binaries:

      Current branch crw-2.8-rhel-8 is up to date.
      Enumerating objects: 2084, done.
      Counting objects: 100% (2084/2084), done.
      Delta compression using up to 2 threads
      Compressing objects: 100% (2040/2040), done.
      Writing objects: 100% (2082/2082), 115.78 MiB | 576.00 KiB/s, done.
      Total 2082 (delta 101), reused 0 (delta 0)
      remote: Can not push commit 138d56b596912aab9a33b2055da2c3ab62627055 to refs/heads/crw-2.8-rhel-8: file .yarn/cache/@patternfly-react-core-npm-4.84.4-72716287a2-908c801732.zip is too big. Max file size is 10485760 bytes.
      remote: Adding big files into git is bad. Once they are committed, they can not be removed and will have to be downloaded with each new clone.
      remote: Please use "rhpkg upload" to put the files into lookaside cache and "rhpkg sources" to download them again.
      remote: If you are absolutely sure you want to commit it, you can override the limit in your commit message by adding the following line. The size is in bytes.
      remote:     - MaxFileSize: 123456
      remote: Alternatively contact EXD SP to adjust the limit for this repository via
      remote:   https://hurl.corp.redhat.com/sp-ticket
      To ssh://pkgs.devel.redhat.com/containers/codeready-workspaces-dashboard
       ! [remote rejected] crw-2.8-rhel-8 -> crw-2.8-rhel-8 (pre-receive hook declined)
      error: failed to push some refs to 'ssh://nboldt@pkgs.devel.redhat.com/containers/codeready-workspaces-dashboard'
      

      Two options are:

      a) build a .yarn/cache tarball and use that w/ rhpkg sources (as we do for Theia)
      b) commit the individual zips using the MaxFileSize override

      Since neither is entirely simple, but since we already do the ol' dockerfile-transform-from-online-vendoring-to-offline-tarball-copy-and-untar approach in other places, that's likely the easier solution here.

      Attachments

        Issue Links

          Activity

            People

              jpinkney-1 Joshua Pinkney (Inactive)
              nickboldt Nick Boldt
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: