XMLWordPrintable

Details

    • False
    • False
    • Undefined

    Description

      Cannot compile CRW operator from latest synced bits in pkgs.devel repo.

      Here are the test failures:

      --- FAIL: TestShouldSetUpCorrectlyInternalPluginRegistryServiceURL (0.06s)
          --- FAIL: TestShouldSetUpCorrectlyInternalPluginRegistryServiceURL/Should_use_'external'_public_plugin_registry_url,_when_internal_network_is_enabled (0.01s)
              che_controller_test.go:1306: ConfigMap  not found: configmaps "che" not found
              che_controller_test.go:1312: plugin registry internal url must be http://external-plugin-registry
          --- FAIL: TestShouldSetUpCorrectlyInternalPluginRegistryServiceURL/Should_use_'external'_public_plugin_registry_url,_when_internal_network_is_disabled (0.03s)
              che_controller_test.go:1306: ConfigMap  not found: configmaps "che" not found
              che_controller_test.go:1312: plugin registry internal url must be http://external-plugin-registry
          --- FAIL: TestShouldSetUpCorrectlyInternalPluginRegistryServiceURL/Should_use_public_plugin_registry_url,_when_internal_network_is_disabled (0.01s)
              che_controller_test.go:1306: ConfigMap  not found: configmaps "che" not found
              che_controller_test.go:1312: plugin registry internal url must be http://plugin-registry/v3
          --- FAIL: TestShouldSetUpCorrectlyInternalPluginRegistryServiceURL/Should_use_internal_plugin_registry_url,_when_internal_network_is_enabled (0.01s)
              che_controller_test.go:1306: ConfigMap  not found: configmaps "che" not found
              che_controller_test.go:1312: plugin registry internal url must be http://plugin-registry.eclipse-che.svc:8080/v3
      
      --- FAIL: TestShouldSetUpCorrectlyInternalDevfileRegistryServiceURL (0.05s)
          --- FAIL: TestShouldSetUpCorrectlyInternalDevfileRegistryServiceURL/Should_use_'external'_devfile_registry_url,_when_internal_network_is_enabled (0.01s)
              che_controller_test.go:1492: ConfigMap  not found: configmaps "che" not found
              che_controller_test.go:1498: devfile registry internal url must be http://external-devfile-registry
          --- FAIL: TestShouldSetUpCorrectlyInternalDevfileRegistryServiceURL/Should_use_'external'_public_devfile_registry_url,_when_internal_network_is_disabled (0.01s)
              che_controller_test.go:1492: ConfigMap  not found: configmaps "che" not found
              che_controller_test.go:1498: devfile registry internal url must be http://external-devfile-registry
          --- FAIL: TestShouldSetUpCorrectlyInternalDevfileRegistryServiceURL/Should_use_public_devfile_registry_url,_when_internal_network_is_disabled (0.01s)
              che_controller_test.go:1492: ConfigMap  not found: configmaps "che" not found
              che_controller_test.go:1498: devfile registry internal url must be http://devfile-registry
          --- FAIL: TestShouldSetUpCorrectlyInternalDevfileRegistryServiceURL/Should_use_internal_devfile_registry_url,_when_internal_network_is_enabled (0.01s)
              che_controller_test.go:1492: ConfigMap  not found: configmaps "che" not found
              che_controller_test.go:1498: devfile registry internal url must be http://devfile-registry.eclipse-che.svc:8080
      
      --- FAIL: TestShouldSetUpCorrectlyInternalCheServerURL (0.04s)
          --- FAIL: TestShouldSetUpCorrectlyInternalCheServerURL/Should_use_public_che-server_url,_when_internal_network_is_disabled (0.02s)
              che_controller_test.go:1627: ConfigMap  not found: configmaps "che" not found
              che_controller_test.go:1633: che-server internal url must be http://che-host/api
          --- FAIL: TestShouldSetUpCorrectlyInternalCheServerURL/Should_use_internal_che-server_url,_when_internal_network_is_enabled (0.02s)
              che_controller_test.go:1627: ConfigMap  not found: configmaps "che" not found
              che_controller_test.go:1633: che-server internal url must be http://che-host.eclipse-che.svc:8080/api
      

      I also noticed we're not syncing the mocks folder to pkgs.devel...

      2021-03-01 19:46:41,007 - atomic_reactor.plugins.imagebuilder - INFO - build github.com/eclipse/che-operator/mocks: cannot load github.com/eclipse/che-operator/mocks: open /che-operator/mocks: no such file or directory
      

      http://download.eng.bos.redhat.com/brewroot/work/tasks/6094/35196094/x86_64.log

      ... so here's a PR to that adds them:

      https://github.com/redhat-developer/codeready-workspaces-operator/pull/44

      But even with the mocks in place, the above test failures occur - see http://download.eng.bos.redhat.com/brewroot/work/tasks/7013/35197013/x86_64.log

      To reproduce locally:

      1. fetch sources from ssh://your-kerberos-user@pkgs.devel.redhat.com/containers/codeready-workspaces-operator
      2. run makeLocalDockerfile.sh to transform brew-friendly dockerfile to one we can run locally (or apply patch below)
      3. watch for failures

      patch to make brew Dockerfile into a locally runnable vesion
      $➔ diff Dockerfile local.Dockerfile -u -1
      --- Dockerfile	2021-03-01 15:22:15.686685915 -0500
      +++ local.Dockerfile	2021-03-01 14:59:22.379188983 -0500
      @@ -15,3 +15,3 @@
       # https://access.redhat.com/containers/?tab=tags#/registry.access.redhat.com/devtools/go-toolset-rhel7
      -FROM devtools/go-toolset-rhel7:1.13.15-4  as builder
      +FROM registry.redhat.io/devtools/go-toolset-rhel7:1.13.15-4  as builder
       ENV PATH=/opt/rh/go-toolset-1.13/root/usr/bin:${PATH} \
      @@ -28,3 +28,3 @@
       # https://access.redhat.com/containers/?tab=tags#/registry.access.redhat.com/ubi8-minimal
      -FROM ubi8-minimal:8.3-291
      +FROM registry.redhat.io/ubi8-minimal:8.3-291
       

      Attachments

        Issue Links

          Activity

            People

              abazko Anatolii Bazko
              nickboldt Nick Boldt
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: