Details
-
Bug
-
Resolution: Done
-
Blocker
-
2.4.0.GA
-
None
-
False
-
False
-
Undefined
Description
Looks like changes made for CRW-1131 in https://github.com/eclipse/che-operator/pull/398 were not fully tested on s390x hardware since they don't work in Brew. 
I tried a few things [1], but I'm still getting test failures when building the 7.18.x branch of che-operator in Brew:
[1] https://github.com/eclipse/che-operator/commits/7.18.x
2020-09-18 21:04:44,744 - atomic_reactor.plugins.imagebuilder - INFO - time="2020-09-18T21:04:44Z" level=fatal msg="Failed to initialize default value: 'registry.redhat.io/rh-sso-7/sso74-openshift-rhel8:7.4'. Environment variable with default value was not found." 2020-09-18 21:04:44,744 - atomic_reactor.plugins.imagebuilder - INFO - FAIL github.com/eclipse/che-operator/pkg/deploy 1.103s
2020-09-18 21:54:40,733 - atomic_reactor.plugins.imagebuilder - INFO - --- FAIL: TestDefaultFromEnv (0.00s) 2020-09-18 21:54:40,733 - atomic_reactor.plugins.imagebuilder - INFO - defaults_test.go:113: Expected registry.redhat.io/rh-sso-7/sso74-openj9-openshift-rhel8:7.4 but was registry.redhat.io/rh-sso-7/sso74-openshift-rhel8:7.4
Kirk suggested a quick fix:
case "RELATED_IMAGE_keycloak": keycloakImageTest = env.Value case "RELATED_IMAGE_keycloak_s390x": keycloakImageTest = env.Value case "RELATED_IMAGE_keycloak_ppc64le": keycloakImageTest = env.Value
but that doesn't seem to work on x86.
