User Story:

cloud-credential-operator should use custom gcp endpoints when they are defined on the cluster infrastructure objects, so that we can deploy disconnected clusters on gcp.

Acceptance Criteria:

Description of criteria:

• if custom endpoints are defined on the infrastructure object, cco creates clients using those endpoints.

(optional) Out of Scope:

The ccoctl binary may need suppport for private endpoints as well. This will update the NewClient function that ccoctl uses, but further work would need to be done to pass in the endpoints from the binary. We should track that in a separate card.

Engineering Details:

• https://github.com/openshift/enhancements/pull/1734
• In the CCO:
  • gcpClient holds the relevant gcp clients (& services)
  • The gcpClient is instantiated by the NewClient function, which will need to be extended to bring in the new endpoints
  • The cloud credential operator calls NewClient via NewClientFromJSON, NewClient looks to be called directly from ccoctl, that should be handled but is out of scope for this card.
  • NewClientFromJSON is called in two places, by the actuator and reconciler:
    • In the context of both of those calling sites, there is a k8s client which can be used to get the infrastructure object
    • There is an existing helper function to get the infrastructure object
    • So the endpoints can be read off that object and passed into the NewClientFromJSON function

This requires/does not require a design proposal.
This requires/does not require a feature gate.