Uploaded image for project: 'OpenShift Installer'
  1. OpenShift Installer
  2. CORS-1910

Azure: Move from deprecated go-autorest API to azidentity package

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Done
    • Icon: Undefined Undefined
    • None
    • None
    • None
    • None
    • Sprint 215, Sprint 216

      The installer uses go-autorest for authentication which uses deprecated ADAL under the hood:

      https://github.com/openshift/installer/blob/master/pkg/asset/installconfig/azure/session.go#L13

      https://github.com/Azure/go-autorest/issues/636

       

      We should move to using the azidentity package:

      https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/azidentity

       

       

      Acceptance Criteria:

      • Authentication uses the new azidentity package
      • All clients can authenticate using the session struct
      • After introducing the new package, attempt to remove these direct adal dependencies from go.mod .] If it is not possible to remove these require statements, document (informally, github or jira comment is fine), why we can't remove them. 
      • compatibility with Azure Stack Hub/GovCloud: users should be able to authenticate to Azure Stack Hub & GovCloud as well as Azure Public Cloud

       

      Make sure to check:

      • dependency between SDK and terraform provider
        • The current sdk version has the azidentity package, so unless it needs updating for other reasons, this should not be needed

       

      Engineering Details

              rdossant Rafael Fonseca dos Santos
              padillon Patrick Dillon
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: