Uploaded image for project: 'OpenShift Console'
  1. OpenShift Console
  2. CONSOLE-5040

Fix existing DataView types to use ConsoleDataViewColumn instead of TableColumn

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Unresolved
    • Icon: Undefined Undefined
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      TableColumn is a legacy type and is not compatible with DataViewTh, since cell is optional in TableColumn but not in DataViewTh

       The following tables are affected by this oversight:

      • packages/console-app/src/components/nodes/NodesPage.tsx:627
      • packages/console-app/src/components/pdb/PDBList.tsx:156
      • packages/console-app/src/components/volume-snapshot/volume-snapshot-class.tsx:139
      • packages/console-app/src/components/volume-snapshot/volume-snapshot-content.tsx:170
      • packages/console-app/src/components/volume-snapshot/volume-snapshot.tsx:283
      • packages/helm-plugin/src/components/details-page/resources/HelmReleaseResourcesList.tsx:22
      • packages/helm-plugin/src/components/list-page/HelmChartRepositoryList.tsx:22
      • packages/helm-plugin/src/components/list-page/HelmReleaseList.tsx:267
      • packages/helm-plugin/src/components/list-page/ProjectHelmChartRepositoryList.tsx:22
      • packages/helm-plugin/src/components/list-page/RepositoriesList.tsx:22
      • public/components/RBAC/bindings.tsx:325
      • public/components/alert-manager.tsx:230
      • public/components/build-config.tsx:330
      • public/components/build.tsx:467
      • public/components/cluster-settings/cluster-operator.tsx:243
      • public/components/cluster-settings/related-objects.tsx:142
      • public/components/configmap.tsx:139
      • public/components/control-plane-machine-set.tsx:342
      • public/components/cron-job.tsx:379
      • public/components/custom-resource-definition.tsx:346
      • public/components/daemon-set.tsx:125
      • public/components/default-resource.tsx:357
      • public/components/deployment-config.tsx:317
      • public/components/deployment.tsx:237
      • public/components/group.tsx:131
      • public/components/hpa.tsx:402
      • public/components/image-stream.tsx:444
      • public/components/job.tsx:319
      • public/components/limit-range.tsx:117
      • public/components/machine-autoscaler.tsx:176
      • public/components/machine-config-pool.tsx:416
      • public/components/machine-config.tsx:266
      • public/components/machine-health-check.tsx:126
      • public/components/machine-set.tsx:423
      • public/components/machine.tsx:285
      • public/components/monitoring/alertmanager/alertmanager-config.tsx:480
      • public/components/persistent-volume-claim.tsx:580
      • public/components/persistent-volume.tsx:262
      • public/components/pod-list.tsx:544
      • public/components/prometheus.tsx:161
      • public/components/secret.tsx:192
      • public/components/stateful-set.tsx:86
      • public/components/storage-class.tsx:171
      • public/components/template-instance.tsx:192
      • public/components/user.tsx:130
      • public/components/volume-attributes-class.tsx:147
         

      AC:

      • Update the use[Whatever]Columns hooks in each of those files to return either ConsoleDataViewColumn or DataViewTh (probably ConsoleDataViewColumn)
      • Add @deprecated tsdoc tag to all VirtualizedTable related types in the SDK

              Unassigned Unassigned
              rh-ee-jaclee Jackson Lee
              None
              None
              None
              None
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: