Uploaded image for project: 'OpenShift Console'
  1. OpenShift Console
  2. CONSOLE-4670

[KNATIVE] Drop remaining createModalLauncher instances and use useOverlay instead

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Duplicate
    • Icon: Undefined Undefined
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      As part of the work on react-router v5 drop, we need to migrate from the createModalLauncher to the useModal hook instead. Before we are able to migrate to useModal, we have to refactor consumers of createModalLauncher to a hook/FC form first.

      There are several such instances within KNATIVE plugin, these are listed in Inventory of createModalLauncher in Console. We should either refactor those to hook equivalent or move them under functional component. Some prior refactors that have been done are a good reference point for what is expected - https://github.com/openshift/console/pull/13506https://github.com/openshift/console/pull/15078 or https://github.com/openshift/console/pull/15063 . 

      AC:

      1. Refactor existing uses of createModalLauncher instances by migrating them to a hook pattern 
      2. Consolidate consumers of the new refactored hook form.
      3. Check the tests. Some of the refactored code could be used in tests.

              Unassigned Unassigned
              rh-ee-mziska Marek Ziska (Inactive)
              None
              None
              None
              None
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: