-
Story
-
Resolution: Done
-
Undefined
-
None
-
None
-
None
-
None
-
Quality / Stability / Reliability
-
False
-
-
False
-
3
-
None
-
None
-
OCP Console - Sprint 275
As part of the work on react-router v5 drop, we need to migrate from the createModalLauncher instances in our codebase and we need to use the useModal hook instead. Before we are able to migrate to useModal we have to refactor consumers of createModalLauncher to be a hook/FC form first.
For webterminal plugin there is one such instance - cloudShellConfirmationModal within cloudShellConfirmationModal.ts. We should refactor it to a hook equivalent which would wrap and return the existing actions. Some prior refactors that have been done are a good reference point for what is expected - https://github.com/openshift/console/pull/13506, https://github.com/openshift/console/pull/15078 or https://github.com/openshift/console/pull/15063 .
AC:
- refactor cloudShellConfirmationModal to a hook form.
- consolidate consumers to use the new hook form instead.
- Fix cloud-shell-actions.spec integration tests.