-
Bug
-
Resolution: Done
-
Undefined
-
None
-
None
-
None
-
None
-
Quality / Stability / Reliability
-
False
-
-
None
-
None
-
None
-
None
-
None
-
None
-
Release Note Not Required
-
n/a
AC:
- All React.useEffects that return a value are explicitly a void function
To test:
- Update React to version 18 locally, then verify that the error no longer pops up in any route
—
React throws errors on version 18 with the following error in the dashboards page (more than just that route but I haven't checked every route):
destroy is not a function
This is one of the component traces:
./packages/console-shared/src/components/dashboard/utilization-card/UtilizationItem.tsx/_c4<@http://localhost:9000/static/main-bundle.js:39819:79
./public/components/dashboard/dashboards-page/cluster-dashboard/utilization-card.tsx/_c2<@http://localhost:9000/static/public_components_dashboard_dashboards-page_cluster-dashboard_utilization-card_tsx-c1f91f65adbbcaffb575.js:1167:129
./public/components/utils/firehose.jsx/ConnectToState<@http://localhost:9000/static/main-bundle.js:156200:134
ConnectFunction@http://localhost:9000/static/vendor-plugins-shared-node_modules_dnd-core_node_modules_redux_es_redux_js-node_modules_react-e6d309-bundle.js:2039:68
Firehose2@http://localhost:9000/static/main-bundle.js:156258:5
ConnectFunction@http://localhost:9000/static/vendor-plugins-shared-node_modules_dnd-core_node_modules_redux_es_redux_js-node_modules_react-e6d309-bundle.js:2039:68
WithDashboardResources@http://localhost:9000/static/public_components_dashboard_dashboards-page_cluster-dashboard_utilization-card_tsx-c1f91f65adbbcaffb575.js:1862:5
ConnectFunction@http://localhost:9000/static/vendor-plugins-shared-node_modules_dnd-core_node_modules_redux_es_redux_js-node_modules_react-e6d309-bundle.js:2039:68
div
Grid@http://localhost:9000/static/vendors~main-chunk-vendors-node_modules_octokit_rest_index_js-node_modules_patternfly_quickstarts_dist_index_es_-0185aa-3bf71d01c809fc89e368.min.js:35012:104
div
UtilizationBody@http://localhost:9000/static/main-bundle.js:39382:25
div
Card@http://localhost:9000/static/vendors~main-chunk-vendors-node_modules_octokit_rest_index_js-node_modules_patternfly_quickstarts_dist_index_es_-0185aa-3bf71d01c809fc89e368.min.js:19827:306
UtilizationCard@http://localhost:9000/static/public_components_dashboard_dashboards-page_cluster-dashboard_utilization-card_tsx-c1f91f65adbbcaffb575.js:1379:68
div
GridItem@http://localhost:9000/static/vendors~main-chunk-vendors-node_modules_octokit_rest_index_js-node_modules_patternfly_quickstarts_dist_index_es_-0185aa-3bf71d01c809fc89e368.min.js:35057:124
div
Grid@http://localhost:9000/static/vendors~main-chunk-vendors-node_modules_octokit_rest_index_js-node_modules_patternfly_quickstarts_dist_index_es_-0185aa-3bf71d01c809fc89e368.min.js:35012:104
div
GridItem@http://localhost:9000/static/vendors~main-chunk-vendors-node_modules_octokit_rest_index_js-node_modules_patternfly_quickstarts_dist_index_es_-0185aa-3bf71d01c809fc89e368.min.js:35057:124
div
Grid@http://localhost:9000/static/vendors~main-chunk-vendors-node_modules_octokit_rest_index_js-node_modules_patternfly_quickstarts_dist_index_es_-0185aa-3bf71d01c809fc89e368.min.js:35012:104
div
DashboardGrid@http://localhost:9000/static/main-bundle.js:36880:23
div
Dashboard@http://localhost:9000/static/main-bundle.js:36790:19
ClusterDashboard@http://localhost:9000/static/dashboards-9f25fb75737c3b043edd.js:421:134
- is duplicated by
-
OCPBUGS-52589 @types/react mismatch with react version
-
- Closed
-