Uploaded image for project: 'OpenShift Console'
  1. OpenShift Console
  2. CONSOLE-3644

Post TypeScript upgrade tech debt related issues

    XMLWordPrintable

Details

    • Story
    • Resolution: Unresolved
    • Undefined
    • None
    • None
    • Foundation

    Description

      As a follow-up to CONSOLE-2501 we have identified additional tech debt related issues.

      Code removals (1)

      • remove public/components/RBAC/edit-rule.jsx since it appears to be unused

      TS typing related fixes

      • avoid using types which are not recommended as per @typescript-eslint/ban-types docs: {}, Function, object
      • use better react-redux types to avoid @ts-ignore suppressions when importing APIs from that package
      • fix typecast to any for kmsProvider in packages/ceph-storage-plugin/src/components/kms-config/kms-config.tsx (may indicate a bug in our type definitions)

      Linter related fixes

      • fix all @typescript-eslint/no-use-before-define suppressions (low risk)
      • fix all tsdoc/syntax suppressions (low risk)
      • fix all react-hooks/rules-of-hooks suppressions (some code changes may be necessary)
      • fix relevant @typescript-eslint/naming-convention suppressions (lower priority)

      Update tooling dependencies

      • bump @typescript-eslint/eslint-plugin and @typescript-eslint/parser to a more recent version (bigger change potential as this will likely yield associated rule config updates)
      • use a newer ESLint version, current one is 6.7.2 [Nov 2019]
      • use a newer Jest version, current one is 21.2.1 [Sep 2017]
      • bump Prettier and related dependencies to a more recent version (lower priority)

      Attachments

        Activity

          People

            Unassigned Unassigned
            vszocs@redhat.com Vojtech Szocs
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: