Uploaded image for project: 'Cockpit'
  1. Cockpit
  2. COCKPIT-1393

Remove and disallow cross page imports

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None
    • cockpit
    • None
    • False
    • Hide

      None

      Show
      None
    • False
    • Testable
    • ?
    • ?
    • rhel-cockpit
    • ?

      It is technically possible and maybe even tempting to import JavaScript pieces from one page into another. We have done this with the superuser dialogs, for example: The systemd/overview and sosreport/sosreport modules used to import stuff from shell/superuser.

      This practice breaks translations however. Our po sorting machine will not include anything outside of a given page except stuff in pkg/lib.

      We could improve our po sorting machine to be more fine grained and collect individual translations instead of files. But cross importing like this is sus for other reasons as well, and we should just not do it.

      Reasons include that it is simply unexpected, will increase coupling between pages needlessly, and might interfere with future improvements where we want to figure out which tests are affected by code changes.

              Unassigned Unassigned
              mvollmer1@redhat.com Marius Vollmer
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: