Uploaded image for project: 'OpenShift Virtualization'
  1. OpenShift Virtualization
  2. CNV-70936

New CPU Load metrics are exposed in the API by mistake - 4.20 backport downstream

XMLWordPrintable

    • CNV I/U Operators Sprint 279
    • None

      Description of problem:

      The new CPU load metrics:
      - kubevirt_vmi_guest_load_15m
      - kubevirt_vmi_guest_load_1m
      - kubevirt_vmi_guest_load_5m
      
      
      The metrics were added to the `v1.VirtualMachineInstanceGuestAgentInfo` struct.
      
      That struct is also used by `GetGuestInfo` for the cmd API (handler <-> launcher). This API is using `v1.VirtualMachineInstanceGuestAgentInfo` as response.
      
      You can see it by running virtctl guestosinf.
      
      Whatever you expose to  `v1.VirtualMachineInstanceGuestAgentInfo` is exposed by metrics and Subresource API.
      
      
      
      As a result, when adding the CPU load metrics to that struct they were added to the API by mistake.
      
      We should move the `Load` out of `v1.VirtualMachineInstanceGuestAgentInfo` to a different struct.

      Version-Release number of selected component (if applicable):

       

      How reproducible:

       

      Steps to Reproduce:

      1.
      2.
      3.
      

      Actual results:

      CPU guest load metrics are reported in the API. Can be seen by running `virtctl guestosinf`.

      Expected results:

      The metrics should not be reported as an API.

      Additional info:

       

              jvilaca@redhat.com João Vilaça
              sradco Shirly Radco
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: