Uploaded image for project: 'OpenShift Virtualization'
  1. OpenShift Virtualization
  2. CNV-70405

ServiceMesh integration uses upstream deprecated annotation instead of label for injection

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Undefined Undefined
    • None
    • CNV v4.19.2
    • CNV Virtualization
    • Quality / Stability / Reliability
    • 0.42
    • False
    • Hide

      None

      Show
      None
    • False
    • None
    • Important
    • None

      Description of problem:

      adding a VirtualMachine or instance into the ServiceMesh requires the annotation
      
      sidecar.istio.io/inject: true
      
      This annotation is deprecated upstream https://istio.io/latest/docs/reference/config/annotations/#SidecarInject and instead shall be on labels instead

       

      Version-Release number of selected component (if applicable):

      channel: stable
      installPlanApproval: Automatic
      name: kubevirt-hyperconverged
      source: redhat-operators
      sourceNamespace: openshift-marketplace
      startingCSV: kubevirt-hyperconverged-operator.v4.19.1
      

      How reproducible:

      everytime

      Steps to Reproduce:

      1. Create a VM/VMI/Template
      2. Add the sidecar injection label
      3. in the virt-launcher pod the istio-proxy container will not get healthy and therefor break communication to any mesh member 
      

      Actual results:

      $ oc get pods virt-launcher-centos-stream9-yellow-pigeon-76-6bl5f -o yaml | yq -r '.status.containerStatuses[]|{"name": .name, "ready": .ready, "started": .started}' -c 
      {"name":"compute","ready":true,"started":true}
      {"name":"guest-console-log","ready":true,"started":true}
      {"name":"istio-proxy","ready":false,"started":false}
      

      Expected results:

      $ oc get pods virt-launcher-centos-stream9-yellow-pigeon-76-7s5cb -o yaml | yq -r '.status.containerStatuses[]|{"name": .name, "ready": .ready, "started": .started}' -c 
      {"name":"compute","ready":true,"started":true}
      {"name":"guest-console-log","ready":true,"started":true}
      {"name":"istio-proxy","ready":true,"started":true}
      

      Additional info:

      Changing the label to the deprecated annotation brings the pod into healty state. Since the annotation is deprecated we need to provide the functionality with the label applied instead.

              tnisan@redhat.com Tal Nisan
              rhn-support-milang Michaela Lang
              Kedar Bidarkar Kedar Bidarkar
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: