Uploaded image for project: 'OpenShift Virtualization'
  1. OpenShift Virtualization
  2. CNV-54344

[cnv-tests network] Refactor ping(): Support ssh and console; separate formatting from execution

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: Undefined Undefined
    • None
    • None
    • CNV Network
    • Quality / Stability / Reliability
    • 0.42
    • False
    • Hide

      None

      Show
      None
    • False
    • None
    • None

      Following discussions in slack and related PRs, we need to refactor our ping() function and address these points:

      1. Totally separating the formatting and building of the command (e.g. adding MTU, adding "-6 for IPv6, etc.) from the execution of the ping action.
      2. Enable executing the command from either console or ssh. Currently we always execute it via ssh, but we need to stop depending on ssh, and allow the ability to execute via console.
        For this point there are 2 suggested approaches, and we will have to decide on one of them:
        a. Add a `connect_method` argument to ping() signature, to determine whether to execute the command via ssh or via console.
        b. Create 2 separate functions that implement the ping: ping_via_console() and ping_via_ssh().

              phoracek@redhat.com Petr Horacek
              ysegev@redhat.com Yossi Segev
              Yossi Segev Yossi Segev
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated: