Uploaded image for project: 'OpenShift Virtualization'
  1. OpenShift Virtualization
  2. CNV-52887

VM controller: Decouple network admitter

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: Undefined Undefined
    • None
    • None
    • CNV Network
    • 3
    • False
    • Hide

      None

      Show
      None
    • False
    • None
    • CNV-38613 - 2024 Code Quality
    • ---
    • ---
    • None

      Currently, the VM controller instantiates the network admitter as part of its startVMI flow [1].

      Decouple it from the VM controller and add a unit test to make sure its being called.

      Check if there is a need to change the field to `spec.template.spec`.

       

       [1]https://github.com/kubevirt/kubevirt/blob/f817fe67692c71801d72633d7f5079395d727e60/pkg/virt-controller/watch/vm/vm.go#L1405

              Unassigned Unassigned
              omisan@redhat.com Orel Misan
              Yossi Segev Yossi Segev
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: