-
Story
-
Resolution: Unresolved
-
Undefined
-
None
-
None
First, make sure that we really need the DeployKubeSecondaryDNS enabler, or we can just change the HCO logic to always act like the feature is enabled. If this field is not needed, deprecate it. If it is needed Add a new field spec.DeployKubeSecondaryDNS and deprecate the old spec.featureGates.DeployKubeSecondaryDNS:
- Add the new spec.DeployKubeSecondaryDNS field, with the default value of "false" (x 2 places in the hyperconverged_types.go file)
- Change the HCO code logic to only use the new field
- deprecate the spec.featureGates.DeployKubeSecondaryDNS field; add a comment that this field is ignored. Remove the default value from the deprecated field (x 3 places in the hyperconverged_types.go file).
- Add 2 json patch entries to the upgradePatches.json file; This should be done both in upstream and downstream:
- Check if the deprecated field value is "true", and if this is the case, copy the deprecated field value to the new field.
- Remove the deprecated field.
- Upstream documentation: Fix the documentation in docs/cluster-configuration.md, to point only to the new field.