If there is a problem during VirtualMachineRestore, like the one described in https://issues.redhat.com/browse/CNV-47105, it is very difficult for the user to get the VM back. 

The system does not reconcile after deleting this object, the VM points to wrong disks and has a leftover .status.restoreInProgress

4.16.1

Always

1. Get into a situation that a VirtualMachineRestore hangs and cannot progress. I'm using https://issues.redhat.com/browse/CNV-47105 as example

$ oc get vmrestore resotre-snapshot-cyan-cockroach-53-1724733464456
NAME                                               TARGETKIND       TARGETNAME          COMPLETE   RESTORETIME   ERROR
resotre-snapshot-cyan-cockroach-53-1724733464456   VirtualMachine   rhel8-aqua-asp-20   false

2. Delete the VirtualMachineRestore object

Now we have 2 problems

A) The VM was not changed back to use the volumes prior to the restore, its stuck pointing to new restore-xyz volumes that may or may not have been created.

B) There is a leftover status that prevents VM start, requiring a manual patch

$ oc get vm rhel8-aqua-asp-20 -o yaml | yq '.status.restoreInProgress'
"resotre-snapshot-cyan-cockroach-53-1724733464456"

$ virtctl start rhel8-aqua-asp-20
Error starting VirtualMachine Internal error occurred: admission webhook "virtualmachine-validator.kubevirt.io" denied the request: Cannot start VM until restore "resotre-snapshot-cyan-cockroach-53-1724733464456" completes

The system should do better to recover and reconcile from such scenarios, without support intervention.

VMs unable to start

VMs able to abort restores and start on previous state