If for whatever reason the source format changes from snapshot -> pvc or pvc -> snapshot. The associated datasources change to match. However the actual source content doesn't change. So now the datasources are pointing to an invalid source and cloning stops working. This is causing confusion.

 

1. Modify the storage profile spec and force the dataImportCronSource to be snapshot if it was PVC or PVC if it was snapshot.
2. Attempt to clone from a template (the template sources will also no longer show up in the UI as available)
3.

Clones fail because the source is not available.
 

Clones to be successful because the source is available.
 

It might make sense that if we detect this situation (which we do since the datasource condition is indicating that the source is not available). That we 'convert' the source from one to the other. So if we have existing PVC sources, and the dataImportCronSource is set to snapshot, then we create a snapshot of the PVC source with the same name. If that is successful,  we then we can delete the PVC source since we have a snapshot now. And vice versa. If the existing source is a snapshot, and the dataImportCronSource is set to PVC, we can restore into a PVC from the snapshot, and then delete the volumesnapshot once the restore is successfully completed (need to make sure we consider WFFC storage)