Uploaded image for project: 'OpenShift Virtualization'
  1. OpenShift Virtualization
  2. CNV-41610

Datavolume webhook shouldn't validate dataSourceRef

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Done
    • Icon: Normal Normal
    • CNV v4.17.0
    • None
    • CNV Storage
    • None
    • Storage Core Sprint 255, Storage Core Sprint 256
    • No

      In webhooks we want to prevent failing requests when they are raceful.

      Currently when creating the datavolume we check in the webhook the function: validateSourceRef
      There we

      1. fail the datavolume creation if the datasourceref doesnt exist yet, which is racy.
      2. After we checked it exists we start validating it, since the source of the datasourceref can be changed we shouldn't fail the datavolume creation.

      Instead we should present an error message in the datavolume status and allow the user to update the source in the datasourceref.

              skagan@redhat.com Shelly Kagan
              skagan@redhat.com Shelly Kagan
              Jenia Peimer Jenia Peimer
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: