Uploaded image for project: 'OpenShift Virtualization'
  1. OpenShift Virtualization
  2. CNV-41517

kubevirt_vmi_vcpu_wait_seconds_total and kubevirt_vmi_vcpu_seconds_total values are wrong

XMLWordPrintable

    • 0.42
    • False
    • Hide

      None

      Show
      None
    • False
    • None
    • No
    • ---
    • ---
    • CNV I/U Operators Sprint 253

      Description of problem:

      In order to move units to seconds, kubevirt_vmi_vcpu_wait_seconds_total and kubevirt_vmi_vcpu_seconds_total are divided by nanoseconds (1000000000), however, according to https://www.libvirt.org/manpages/virsh.html#domstats:
vcpu.<num>.time - virtual cpu time spent by virtual CPU <num> (in microseconds)
vcpu.<num>.wait - virtual cpu time spent by virtual CPU <num> waiting on I/O (in microseconds).
They should be divided by microseconds (1000000).

      Version-Release number of selected component (if applicable):

       

      How reproducible:

      always

      Steps to Reproduce:

      1. Look at https://github.com/kubevirt/kubevirt/blob/a72353209753b177a2d71abc7204c6254befc89a/pkg/monitoring/domainstats/prometheus/prometheus.go#L272.

      Actual results:

      kubevirt_vmi_vcpu_wait_seconds_total and kubevirt_vmi_vcpu_seconds_total are divided by nanoseconds

      Expected results:

      kubevirt_vmi_vcpu_wait_seconds_total and kubevirt_vmi_vcpu_seconds_total are divided by microseconds

      Additional info:

       

      Fix PRs:

      4.17 - https://github.com/kubevirt/kubevirt/pull/11858

      4.16 - https://github.com/kubevirt/kubevirt/pull/11878

      4.15 - https://github.com/kubevirt/kubevirt/pull/11879

            aadmi@redhat.com Assaf Admi
            aadmi@redhat.com Assaf Admi
            Debarati Basu-Nag Debarati Basu-Nag
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: