Uploaded image for project: 'OpenShift Virtualization'
  1. OpenShift Virtualization
  2. CNV-38686

Webhooks should not depend on foreign data

XMLWordPrintable

    • no-remote-validation
    • 77
    • To Do
    • CNV-38613 - 2024 Code Quality
    • CNV-386132024 Code Quality
    • 0% To Do, 0% In Progress, 100% Done
    • dev-ready, doc-ready, po-ready, qe-ready, ux-ready

      Goal

      Avoid races in KubeVirt and ensure it is eventually consistent.

      Requirements

      • List all admission webhooks in KubeVirt, and review each.
      • Ensure that it does not attempt to peak outside of the modified value.
      • There may be exceptions, such as:
        • Clear, real-life, documented customer case report requesting early input validation.
        • Validation of non-KubeVirt resources
      • Remaining validation must be commented on and explained e.g.
        // This code is raceful. We keep it here in order to provide a quick feedback to an actual end user who enters a wrong input. Cf. bug report URL
        or
        // This code is raceful. We keep it because fixing it properly is going to be complex and we plan to delete this code anyway.
      • Remaining web-hook validation should have a matching reconciliation-loop validation.

      Non-Requirements

      •  

      Notes

      • Any additional details or decisions made/needed

            sgott@redhat.com Stuart Gott
            dkenigsb@redhat.com Dan Kenigsberg
            Kedar Bidarkar Kedar Bidarkar
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: