-
Bug
-
Resolution: Obsolete
-
Normal
-
None
-
None
-
2
-
False
-
-
False
-
CNV Virtualization Sprint 248
-
Medium
-
None
Description of problem:
Duplicated lines existed in virt-controller deployment command part after adding annotation to HyperConverged CR
Version-Release number of selected component (if applicable):
CNV4.10
How reproducible:
100%
Steps to Reproduce:
1. In order to use the latest libvirt and qemu-kvm packages in CNV,
I rebuild the virt-launcher and virt-handler images.
Then edit the kubevirt-hyperconverged to use the new images.
- oc edit hco kubevirt-hyperconverged -n openshift-cnv
apiVersion: hco.kubevirt.io/v1beta1
kind: HyperConverged
metadata:
annotations:
deployOVS: "false"
kubevirt.kubevirt.io/jsonpatch: |-
[
{
"op": "add",
"path": "/spec/customizeComponents/patches",
"value":
[
Unknown macro: { "patch"},
Unknown macro: { "patch"}]
}
]
2. Check the virt-controller deployment, there are 12 lines for --launcher-image.
- oc get deployment virt-controller -n openshift-cnv -o yaml
apiVersion: apps/v1
kind: Deployment
metadata:
annotations:
deployment.kubernetes.io/revision: "2"
kubevirt.io/customizer-identifier: 4f3c28d37bee893571dab3a4c45419877c7e6843
kubevirt.io/generation: "2"
kubevirt.io/install-strategy-identifier: 70f44ec662a14ef76e3a42cbff2c9160dbf938e6
kubevirt.io/install-strategy-registry: registry.redhat.io/container-native-virtualization
kubevirt.io/install-strategy-version: sha256:1513c106d035638ab7092e6a6685bbc77c6499f8e312a34c20a1296bdd8095ab
creationTimestamp: "2022-03-07T08:26:54Z"
generation: 2
labels:
app.kubernetes.io/component: compute
app.kubernetes.io/managed-by: virt-operator
app.kubernetes.io/name: virt-controller
app.kubernetes.io/part-of: hyperconverged-cluster
app.kubernetes.io/version: 4.10.0
kubevirt.io: virt-controller
name: virt-controller
namespace: openshift-cnv
......
containers:
- command:
- virt-controller
- --launcher-image
- registry.redhat.io/container-native-virtualization/virt-launcher@sha256:944f88e4e9c008f8f15ac98b63dd0492f6b4e634c8ff6a81ec5085119dfd410e
- --port
- "8443"
- -v
- "2"
- --launcher-image=quay.io/libvirt_v2v_cnv/virt-launcher:v4.10.0-197
- --launcher-image=quay.io/libvirt_v2v_cnv/virt-launcher:v4.10.0-197
- --launcher-image=quay.io/libvirt_v2v_cnv/virt-launcher:v4.10.0-197
- --launcher-image=quay.io/libvirt_v2v_cnv/virt-launcher:v4.10.0-197
- --launcher-image=quay.io/libvirt_v2v_cnv/virt-launcher:v4.10.0-197
- --launcher-image=quay.io/libvirt_v2v_cnv/virt-launcher:v4.10.0-197
- --launcher-image=quay.io/libvirt_v2v_cnv/virt-launcher:v4.10.0-197
- --launcher-image=quay.io/libvirt_v2v_cnv/virt-launcher:v4.10.0-197
- --launcher-image=quay.io/libvirt_v2v_cnv/virt-launcher:v4.10.0-197
- --launcher-image=quay.io/libvirt_v2v_cnv/virt-launcher:v4.10.0-197
- --launcher-image=quay.io/libvirt_v2v_cnv/virt-launcher:v4.10.0-197
- --launcher-image=quay.io/libvirt_v2v_cnv/virt-launcher:v4.10.0-197
3. Check the virt-handler DaemonSet, the change is correct
- oc get DaemonSet virt-handler -n openshift-cnv -o yaml
apiVersion: apps/v1
kind: DaemonSet
metadata:
annotations:
deprecated.daemonset.template.generation: "2"
kubevirt.io/customizer-identifier: 4f3c28d37bee893571dab3a4c45419877c7e6843
kubevirt.io/generation: "2"
kubevirt.io/install-strategy-identifier: 70f44ec662a14ef76e3a42cbff2c9160dbf938e6
kubevirt.io/install-strategy-registry: registry.redhat.io/container-native-virtualization
kubevirt.io/install-strategy-version: sha256:1513c106d035638ab7092e6a6685bbc77c6499f8e312a34c20a1296bdd8095ab
creationTimestamp: "2022-03-07T08:26:54Z"
generation: 4
labels:
app.kubernetes.io/component: compute
app.kubernetes.io/managed-by: virt-operator
app.kubernetes.io/part-of: hyperconverged-cluster
app.kubernetes.io/version: 4.10.0
kubevirt.io: virt-handler
name: virt-handler
namespace: openshift-cnv
......
spec:
containers:
- command:
- virt-handler
......
image: quay.io/libvirt_v2v_cnv/virt-handler:v4.10.0-197
......
initContainers:
- args:
- node-labeller.sh
command: - /bin/sh
- -c
image: quay.io/libvirt_v2v_cnv/virt-launcher:v4.10.0-197
Actual results:
In step2, Check the virt-controller deployment, there are 12 lines for --launcher-image
Expected results:
In step2, Check the virt-controller deployment, 1 line for --launcher-image
Additional info:
- clones
-
CNV-16879 [2062966] Duplicated lines existed in virt-controller deployment command part after adding annotation to HyperConverged CR
- Closed
- links to
-
RHEA-2023:122979 OpenShift Virtualization 4.16.0 Images