Uploaded image for project: 'OpenShift Virtualization'
  1. OpenShift Virtualization
  2. CNV-29337

[2211671] [KubeVirt] Additional metrics names failed promlint linter

XMLWordPrintable

    • Moderate
    • No

      Description of problem:
      We created a metric name linter in kubevirt based on promlint: https://github.com/kubevirt/kubevirt/pull/9709.
      This metrics names failed:
      kubevirt_allocatable_nodes_count: non-histogram and non-summary metrics should not have "_count" suffix
      kubevirt_kvm_available_nodes_count: non-histogram and non-summary metrics should not have "_count" suffix
      kubevirt_virt_api_up_total: non-counter metrics should not have "_total" suffix
      kubevirt_virt_controller_ready_total: non-counter metrics should not have "_total" suffix
      kubevirt_virt_controller_up_total: non-counter metrics should not have "_total" suffix
      kubevirt_virt_handler_up_total: non-counter metrics should not have "_total" suffix
      kubevirt_virt_operator_leading_total: non-counter metrics should not have "_total" suffix
      kubevirt_virt_operator_ready_total: non-counter metrics should not have "_total" suffix
      kubevirt_virt_operator_up_total: non-counter metrics should not have "_total" suffix
      kubevirt_vmi_phase_count: non-histogram and non-summary metrics should not have "_count" suffix

      Version-Release number of selected component (if applicable):
      4.13

      How reproducible:
      100%

      Steps to Reproduce:
      1.cd kubevirt
      2.make lint-metrics

      Actual results:
      some metric names are not aligned with promlint.

      Expected results:
      Metrics named will be aligned with promlint linter and Prometheus best practices.

      Additional info:
      as for now the list of metrics are ignored in the linter.

              sradco Shirly Radco
              alitman@redhat.com Aviv Litman
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: