Uploaded image for project: 'OpenShift Virtualization'
  1. OpenShift Virtualization
  2. CNV-28961

[2209046] kubevirt_vmi_cpu_affinity metric is enriched with an excessive amount of labels

XMLWordPrintable

    • CNV I/U Operators Sprint 238, CNV I/U Operators Sprint 239, CNV I/U Operators Sprint 240, CNV I/U Operators Sprint 241, CNV I/U Operators Sprint 242
    • Moderate
    • No

      Description of problem:
      Issue reported in https://github.com/kubevirt/kubevirt/issues/9713.

      In https://github.com/kubevirt/kubevirt/pull/5191 the kubevirt_vmi_cpu_affinity metric got introduced. Given X pcpus and Y vcpus, there can be up to X*Y labels generated for a single VM.

      A concrete example: 192 pcore and 48 vcpu lead to 48*192 (9216!) labels. This is something which can not easily be digested by all kinds of metric pipelines.

      Version-Release number of selected component (if applicable):

      How reproducible:

      Steps to Reproduce:
      1.Starting a VM with a single vCPU without explicit pinning, has an affinity for all CPUs.
      2.
      3.

      Actual results:

      Expected results:
      Let's see that we shrink or remove this. Since this is "just" a boolean map expressing CPU pinning layout, this looks like something which should not be exposed via core kubevirt via prometheus metrics.

      Just doing this for explicit cpu pinning may be an option, but even then getting 50-100 labels would be the result which is probably still above an acceptable number of labels per metric, considering that VM labels and such are added as well and we want to leave room for user-specific labels.

      Additional info:
      Example for a single vCPU on a 8-core machine:

      1. virsh vcpuinfo default_fedora
        VCPU: 0
        CPU: 4
        State: running
        CPU time: 33.5s
        CPU Affinity: yyyyyyyy

      Note the 8 `y`s

              jvilaca@redhat.com João Vilaça
              sradco Shirly Radco
              Ahmad Hafi Ahmad Hafi
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: