[2182534] spec.firmware.bootloader is not copied while cloning a UEFI VM

+++ This bug was initially created as a clone of Bug #2181515 +++

Description of problem:

VM is having UEFI bootloader:

~~~
oc get vm rhel8-i68a2hmbnvp4r2we -o yaml|yq '.spec.template.spec.domain.firmware'
{
"bootloader": {
"efi":

{ "secureBoot": false }

}
}
~~~

Tried cloning the VM and the cloned VM doesn't have the UEFI and will use BIOS.

~~~

1. oc get vm rhel8-i68a2hmbnvp4r2we-clone -o yaml|yq '.spec.template.spec.domain.firmware'
   null
   ~~~

Version-Release number of selected component (if applicable):

OpenShift Virtualization 4.12.0

How reproducible:

100%

Steps to Reproduce:

1. Create a VM with UEFI, ie spec.bootloader = efi.
2. Try cloning this VM and check the definition of the cloned VM.
3. spec.firmware.bootloader is not copied and it will use BIOS.

Actual results:

spec.firmware.bootloader is not copied while cloning a UEFI VM

Expected results:

It should keep the bootloader configuration.

Additional info:

— Additional comment from Guohua Ouyang on 2023-03-27 09:21:09 CST —

This is the UX issue and could reproduce it.

— Additional comment from Guohua Ouyang on 2023-03-29 07:24:51 CST —

verified on upstream latest