Uploaded image for project: 'OpenShift Virtualization'
  1. OpenShift Virtualization
  2. CNV-27054

[2179660] [HCO] Metric names fail in metrics name linter

XMLWordPrintable

    • False
    • Hide

      None

      Show
      None
    • False
    • RELEASE_PENDING
    • Release Notes
    • Hide
      Many OpenShift Virtualization metrics have changed or will change in a future version. These changes could affect your custom dashboards. See OpenShift Virtualization 4.14 metric changes for details. (BZ#2179660)

      https://access.redhat.com/articles/7028805
      Show
      Many OpenShift Virtualization metrics have changed or will change in a future version. These changes could affect your custom dashboards. See OpenShift Virtualization 4.14 metric changes for details. (BZ#2179660) https://access.redhat.com/articles/7028805
    • Deprecated Functionality
    • Done
    • ---
    • ---
    • CNV I/U Operators Sprint 237, CNV I/U Operators Sprint 238, CNV I/U Operators Sprint 239, CNV I/U Operators Sprint 240
    • No

      Description of problem:
      We added a metric name linter, that will check if the metric name meets the best practices requirements see: https://github.com/kubevirt/hyperconverged-cluster-operator/pull/2291.
      The linter failed with the following errors:

      • kubevirt_hco_out_of_band_modifications_count: counter metrics should have 'total' suffix.
      • kubevirt_hco_out_of_band_modifications_count: non-histogram and non-summary metrics should not have 'count' or 'sum'
      • kubevirt_hco_unsafe_modification_count: non-histogram and non-summary metrics should not have 'count' or 'sum' suffix.

      We should updates the names:

      • `kubevirt_hco_out_of_band_modifications_count` to `kubevirt_hco_out_of_band_modifications_total`.
      • `kubevirt_hco_unsafe_modification_count` to `kubevirt_hco_number_of_unsafe_modifications`.

      Version-Release number of selected component (if applicable):
      4.13

      How reproducible:
      100%

      Steps to Reproduce:
      1. open a pr
      2. see the sanity check
      3. see the metric name linter errors

      Actual results:
      metric names are not valid.

      Expected results:
      metrics names are valid.

              sradco Shirly Radco
              alitman@redhat.com Aviv Litman
              Debarati Basu-Nag Debarati Basu-Nag
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: