-
Bug
-
Resolution: Done
-
Blocker
-
None
-
False
-
-
False
-
RELEASE_PENDING
-
Release Notes
-
-
Deprecated Functionality
-
Done
-
---
-
---
-
-
CNV I/U Operators Sprint 237, CNV I/U Operators Sprint 238, CNV I/U Operators Sprint 239, CNV I/U Operators Sprint 240
-
No
Description of problem:
We added a metric name linter, that will check if the metric name meets the best practices requirements see: https://github.com/kubevirt/hyperconverged-cluster-operator/pull/2291.
The linter failed with the following errors:
- kubevirt_hco_out_of_band_modifications_count: counter metrics should have 'total' suffix.
- kubevirt_hco_out_of_band_modifications_count: non-histogram and non-summary metrics should not have 'count' or 'sum'
- kubevirt_hco_unsafe_modification_count: non-histogram and non-summary metrics should not have 'count' or 'sum' suffix.
We should updates the names:
- `kubevirt_hco_out_of_band_modifications_count` to `kubevirt_hco_out_of_band_modifications_total`.
- `kubevirt_hco_unsafe_modification_count` to `kubevirt_hco_number_of_unsafe_modifications`.
Version-Release number of selected component (if applicable):
4.13
How reproducible:
100%
Steps to Reproduce:
1. open a pr
2. see the sanity check
3. see the metric name linter errors
Actual results:
metric names are not valid.
Expected results:
metrics names are valid.
- is related to
-
CNV-29048 Release note: CHANGE
- Closed
- external trackers
- links to
- mentioned on
(1 mentioned on)