Goal

Expose the new hot-plug feature to customers through the UI.

User Stories

• As a developer,
  • I want to be able to plug NICs into my VM without the need to restart it,
    to avoid downtime of my application.
  • I want to be able to select a secondary interface of type "bridge" and
    request it to be hot-unplugged with a UI consistent with that of disk unplug

Non-Requirements

• <List of things not included in this epic, to alleviate any doubt raised during the grooming process.>

Notes

• The current behavior it that when a new NIC is added to a VM, a dialog shows up asking for restart: "Pending Changes: The following areas have pending changes that will be applied when this VirtualMachine is restarted."
• In case of newly added bridge CNI NICs, the dialog should also offer an option to Migrate the VM: "The following areas have pending changes that will be applied when this VirtualMachine is restarted or migrated."

Tasks

Plug:

When a NIC with a type of Bridge is added:

• The alert dialog at the top of the Add network interface modal will say:
  • title: 'Restart or live migration required to apply changes'
  • text: 'The changes you have made require this VirtualMachine to be restarted or live migrated.'
• The following helper text will display under the Type field in the Add network interface modal: 'Hot plug is enabled only for "Bridge" type'
• The Pending Changes alert dialog at the top of the VM page will indicate that for any bridge type NICs, live migration will also apply the change

Unplug:

• The user will be able to initiate hot-unplug of bridged network interfaces in the same manner as disk hot-unplug
• When the user initiates hot-unplug, the `virtctl removeinterface` command will be called. This is similar to the flow of hot-plug.
• After a hot-plug has been initiated the  Pending changes alert dialog will appear at the top of the VM details screen instructing the
  user to restart or live-migrate the VM.

Done Checklist