+++ This bug was initially created as a clone of Bug #2159096 +++

Description of problem:
VM with HotPluggable disks and namespace defined LimitRanges won't restart due to hardcoded Limits

Version-Release number of selected component (if applicable):
4.11

How reproducible:
Always

Steps to Reproduce:
1. setting specific LimitRange on NameSpace/core on an RHOCP cluster
apiVersion: v1
kind: LimitRange
metadata:
name: resource-limits
spec:
limits:

• type: Container
  maxLimitRerquestRatio:
  memory: "1"
  max:
  ephemeral-storage: "20Gi"
  memory: "32Gi"
  min:
  memory: "32Mi"
  default:
  ephemeral-storage: "200Mi"
  memory: "32Mi"
  defaultRequest:
  ephemeral-storage: "50Mi"
• type: openshift.io/Image
  max:
  storage: 1Gi
  2. vms which had additional dataVolumes and the hotpluggable option set to true couldn't restart properly with the error.
  3.

Actual results:
Warning FailedCreate 0m27s virtualmachine-controller Error creating attachment pod: pods "hp-volume-4d7hc" is forbidden: [minimum memory usage per Container is 32Mi, but request is 2M, memory max limit to request ratio per Container is 1, but provided ratio is 40.000000]

Expected results:
VMs and hotplug works well

Additional info:
The suspicion is that this is caused by HotplugAttachmentPod, since in the upstream code the resource requests and limits seem to be hard coded.

— Additional comment from Yan Du on 2023-01-08 14:03:40 UTC —

The bug is clone from https://issues.redhat.com/browse/CNV-22529 (CNV-4.10)