Description of problem: ConsolePlugin kubevirt-plugin is not getting reconciled by hco
Version-Release number of selected component (if applicable):
4.11.0
How reproducible:
100%
Steps to Reproduce:
1. Add a label to metadata.label of ConsolePlugin kubevirt-plugin
2. Wait for it to be overwritten by hco
3.
Actual results:
It never gets overwritten:
[cnv-qe-jenkins@c01-dbn-411-fv5nk-executor ~]$ kubectl get ConsolePlugin kubevirt-plugin -A -o yaml
apiVersion: console.openshift.io/v1alpha1
kind: ConsolePlugin
metadata:
creationTimestamp: "2022-05-22T00:22:27Z"
generation: 1
labels:
app: kubevirt-hyperconverged
app.kubernetes.io/component: deployment
app.kubernetes.io/managed-by: hco-operator
app.kubernetes.io/part-of: hyperconverged-cluster
app.kubernetes.io/version: 4.11.0
temp_label: test
name: kubevirt-plugin
resourceVersion: "3176461"
uid: 25fdac9c-a79c-4679-8247-3033d6193e8f
spec:
displayName: Kubevirt Console Plugin
service:
basePath: /
name: kubevirt-plugin-service
namespace: openshift-cnv
port: 9443
[cnv-qe-jenkins@c01-dbn-411-fv5nk-executor ~]$
==================
[cnv-qe-jenkins@c01-dbn-411-fv5nk-executor ~]$ kubectl get hco kubevirt-hyperconverged -n openshift-cnv -o json| jq '.status.relatedObjects[] | select(.kind == "ConsolePlugin")'
{
"apiVersion": "console.openshift.io/v1alpha1",
"kind": "ConsolePlugin",
"name": "kubevirt-plugin",
"resourceVersion": "3176461",
"uid": "25fdac9c-a79c-4679-8247-3033d6193e8f"
}
[cnv-qe-jenkins@c01-dbn-411-fv5nk-executor ~]$
==================
{"level":"info","ts":1653269542.2634776,"logger":"controller_hyperconverged","msg":"ConsolePlugin already exists","Request.Namespace":"openshift-cnv","Request.Name":"kubevirt-hyperconverged","ConsolePlugin.Namespace":"","ConsolePl
ugin.Name":"kubevirt-plugin"}
{"level":"info","ts":1653269542.2634869,"logger":"controller_hyperconverged","msg":"Reconcile complete","Request.Namespace":"openshift-cnv","Request.Name":"kubevirt-hyperconverged"}
{"level":"info","ts":1653269542.2634926,"logger":"controller_hyperconverged","msg":"No component operator reported negatively","Request.Namespace":"openshift-cnv","Request.Name":"kubevirt-hyperconverged"}
{"level":"info","ts":1653269542.2635198,"logger":"controller_hyperconverged","msg":"setting the Upgradeable operator condition","Request.Namespace":"openshift-cnv","Request.Name":"kubevirt-hyperconverged","requested status":true}
{"level":"error","ts":1653269542.2787266,"logger":"controller_hyperconverged","msg":"Failed to update HCO Status","Request.Namespace":"openshift-cnv","Request.Name":"kubevirt-hyperconverged","error":"Operation cannot be fulfilled
on hyperconvergeds.hco.kubevirt.io \"kubevirt-hyperconverged\": the object has been modified; please apply your changes to the latest version and try again","stacktrace":"github.com/kubevirt/hyperconverged-cluster-operator/control
lers/hyperconverged.(*ReconcileHyperConverged).updateHyperConverged\n\t/remote-source/app/controllers/hyperconverged/hyperconverged_controller.go:556\ngithub.com/kubevirt/hyperconverged-cluster-operator/controllers/hyperconverged.
(*ReconcileHyperConverged).Reconcile\n\t/remote-source/app/controllers/hyperconverged/hyperconverged_controller.go:304\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\t/remote-source/app/vendor/si
gs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:114\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/remote-source/app/vendor/sigs.k8s.io/controller-runtime/pkg/internal
/controller/controller.go:311\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/remote-source/app/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:266\nsigs.k8
s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/remote-source/app/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:227"}
{"level":"error","ts":1653269542.278778,"logger":"controller.hyperconverged-controller","msg":"Reconciler error","name":"kubevirt-hyperconverged","namespace":"openshift-cnv","error":"Operation cannot be fulfilled on hyperconverged
s.hco.kubevirt.io \"kubevirt-hyperconverged\": the object has been modified; please apply your changes to the latest version and try again","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).process
NextWorkItem\n\t/remote-source/app/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/remote-source/app/vendor/si
gs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:227"}
{"level":"info","ts":1653269542.28402,"logger":"controller_hyperconverged","msg":"Reconciling HyperConverged operator","Request.Namespace":"openshift-cnv","Request.Name":"kubevirt-hyperconverged"}
{"level":"info","ts":1653269542.2840986,"logger":"controller_hyperconverged","msg":"KubeVirtPriorityClass already exists","Request.Namespace":"openshift-cnv","Request.Name":"kubevirt-hyperconverged","KubeVirtPriorityClass.Namespac
e":"","KubeVirtPriorityClass.Name":"kubevirt-cluster-critical"}
{"level":"info","ts":1653269542.2842393,"logger":"controller_hyperconverged","msg":"KubeVirt already exists","Request.Namespace":"openshift-cnv","Request.Name":"kubevirt-hyperconverged","KubeVirt.Namespace":"openshift-cnv","KubeVi
rt.Name":"kubevirt-kubevirt-hyperconverged"}
Expected results:
Any changes to ConsolePlugin kubevirt-plugin would be overwritten by hco.
Additional info: