Description of problem:

enactment goes to pending even when mavunavailable is set to !00% in nncp. This state is not desired as we are expecting progressing when maxunavailable is 100%.

Version-Release number of selected component (if applicable):
4.9+

How reproducible:

always
Steps to Reproduce:
1. trigger a policy and monitor states
2.
3.

Actual results:

enactment going into "pending"

Expected results:

enactment should not acquire pending state

Additional info:

policy :

{'apiVersion': 'nmstate.io/v1', 'kind': 'NodeNetworkConfigurationPolicy', 'metadata':

{'name': 'nmstate-policy'}

, 'spec': {'desiredState': {'interfaces': [{'name': 'brstatetest', 'type': 'linux-bridge', 'state': 'up', 'bridge': {'options': {'stp': {'enabled': False}}, 'port': [

{'name': 'ens8'}

]}, 'ipv4':

{'enabled': False, 'dhcp': False, 'auto-dns': True}

, 'ipv6': {'enabled': False}}]}, 'nodeSelector':

{'node-role.kubernetes.io/worker': ''}

, 'maxUnavailable': '100%'}}

Logs:

INFO Complete condition of n-awax-410-2-zmsps-worker-0-hxrpb NNCE : [

{'lastHearbeatTime': '2021-12-05T22:54:47Z', 'lastTransitionTime': '2021-12-05T22:54:47Z', 'message': 'Applying desired state', 'reason': 'ConfigurationProgressing', 'status': 'True', 'type': 'Progressing'}

,

{'lastHearbeatTime': '2021-12-05T22:54:47Z', 'lastTransitionTime': '2021-12-05T22:54:47Z', 'reason': 'ConfigurationProgressing', 'status': 'Unknown', 'type': 'Failing'}

,

{'lastHearbeatTime': '2021-12-05T22:54:47Z', 'lastTransitionTime': '2021-12-05T22:54:47Z', 'reason': 'ConfigurationProgressing', 'status': 'Unknown', 'type': 'Available'}

,

{'lastHearbeatTime': '2021-12-05T22:54:47Z', 'lastTransitionTime': '2021-12-05T22:54:47Z', 'reason': 'ConfigurationProgressing', 'status': 'False', 'type': 'Pending'}

,

{'lastHearbeatTime': '2021-12-05T22:54:47Z', 'lastTransitionTime': '2021-12-05T22:54:47Z', 'reason': 'ConfigurationProgressing', 'status': 'False', 'type': 'Aborted'}

]
ocp_resources.utils 2021-12-05 22:54:48 INFO Elapsed time: 1.0871634483337402
tests.network.nmstate.test_nncp_fields 2021-12-05 22:54:48 INFO Initial status of n-awax-410-2-zmsps-worker-0-hxrpb with status=True when policy is applied : Progressing
ocp_resources.utils 2021-12-05 22:54:48 INFO Elapsed time: 1.062262773513794
tests.network.nmstate.test_nncp_fields 2021-12-05 22:54:48 INFO Complete condition of n-awax-410-2-zmsps-worker-0-qsplw NNCE : [

{'lastHearbeatTime': '2021-12-05T22:54:47Z', 'lastTransitionTime': '2021-12-05T22:54:47Z', 'message': 'Applying desired state', 'reason': 'ConfigurationProgressing', 'status': 'True', 'type': 'Progressing'}

,

{'lastHearbeatTime': '2021-12-05T22:54:47Z', 'lastTransitionTime': '2021-12-05T22:54:47Z', 'reason': 'ConfigurationProgressing', 'status': 'Unknown', 'type': 'Failing'}

,

{'lastHearbeatTime': '2021-12-05T22:54:47Z', 'lastTransitionTime': '2021-12-05T22:54:47Z', 'reason': 'ConfigurationProgressing', 'status': 'Unknown', 'type': 'Available'}

,

{'lastHearbeatTime': '2021-12-05T22:54:47Z', 'lastTransitionTime': '2021-12-05T22:54:47Z', 'reason': 'ConfigurationProgressing', 'status': 'False', 'type': 'Pending'}

,

{'lastHearbeatTime': '2021-12-05T22:54:47Z', 'lastTransitionTime': '2021-12-05T22:54:47Z', 'reason': 'ConfigurationProgressing', 'status': 'False', 'type': 'Aborted'}

]
tests.network.nmstate.test_nncp_fields 2021-12-05 22:54:48 INFO Complete condition of n-awax-410-2-zmsps-worker-0-mrrnr NNCE : [

{'lastHearbeatTime': '2021-12-05T22:54:47Z', 'lastTransitionTime': '2021-12-05T22:54:47Z', 'message': 'Max unavailable node limit reached', 'reason': 'MaxUnavailableLimitReached', 'status': 'True', 'type': 'Pending'}

,

{'lastHearbeatTime': '2021-12-05T22:54:47Z', 'lastTransitionTime': '2021-12-05T22:54:47Z', 'reason': 'MaxUnavailableLimitReached', 'status': 'False', 'type': 'Aborted'}

,

{'lastHearbeatTime': '2021-12-05T22:54:47Z', 'lastTransitionTime': '2021-12-05T22:54:47Z', 'message': 'Max unavailable node limit reached', 'reason': 'MaxUnavailableLimitReached', 'status': 'False', 'type': 'Progressing'}

,

{'lastHearbeatTime': '2021-12-05T22:54:47Z', 'lastTransitionTime': '2021-12-05T22:54:47Z', 'reason': 'MaxUnavailableLimitReached', 'status': 'False', 'type': 'Failing'}

,

{'lastHearbeatTime': '2021-12-05T22:54:47Z', 'lastTransitionTime': '2021-12-05T22:54:47Z', 'reason': 'MaxUnavailableLimitReached', 'status': 'False', 'type': 'Available'}

]
tests.network.nmstate.test_nncp_fields 2021-12-05 22:54:48 INFO Initial status of n-awax-410-2-zmsps-worker-0-qsplw with status=True when policy is applied : Progressing
tests.network.nmstate.test_nncp_fields 2021-12-05 22:54:48 INFO Initial status of n-awax-410-2-zmsps-worker-0-mrrnr with status=True when policy is applied : Pending
tests.network.nmstate.test_nncp_fields 2021-12-05 22:54:48 INFO Combined Status of threads: ['Progressing', 'Pending', 'Progressing']