User Story:

As a HyperShift CLI, I want:

• the validate/complete function signatures to be unified across cloud providers

so that

• the maintenance of these functions will be easier.
• an interface can be defined on top of these functions

Context:

This ticket originated from a code review discussion on PR #4538. The request is to ensure that the public Validate() function (following the pattern Steve introduced) has the same signature across all platforms. This would allow defining an interface on top of these functions.

Platform-specific validation functions (e.g., ValidateMgmtClusterSupportsNodePoolCPUType) can have different signatures as needed.

The TODO pattern to use in code is:

// TODO: unify Validate/Complete signatures across providers (CNTRLPLANE-644)

Acceptance Criteria:

Description of criteria:

• The Validate() and Complete() functions are unified across providers with consistent signatures
• An interface is defined for these functions
• Platform-specific validation functions are refactored as needed while maintaining their specialized parameters

(optional) Out of Scope:

• • Platform-specific helper functions like ValidateMgmtClusterSupportsNodePoolCPUType do not need unified signatures

Engineering Details:

• Originating PR: https://github.com/openshift/hypershift/pull/4538
• Code review discussion: https://github.com/openshift/hypershift/pull/4538#discussion_r1764589754
• Pattern reference: Follow the pattern Steve introduced for platform validation
• We may need to add a NodePool validation function for AWS create cluster in this ticket as well