-
Sub-task
-
Resolution: Unresolved
-
Undefined
-
None
-
None
-
None
-
None
-
None
-
False
-
-
False
-
None
-
None
-
None
-
None
-
None
Submit the PKI API design for formal review and approval by the OpenShift API reviewers.
Process
- Open PR in openshift/api repository with PKI API types
- Request review from API approvers (@deads2k, @JoelSpeed)
- Add api-review label to PR
- Present API design in API review meeting if required
- Address all reviewer feedback
- Obtain LGTM from required approvers
- Update enhancement with API review approval status
API Review Checklist
- API follows openshift/api conventions (README.md)
- All required Go annotations present (+genclient, +k8s:deepcopy-gen, etc.)
- PKI and PKIList types defined with proper tags
- Compatibility level documented (starting at Level 4)
- OpenAPI validation markers correct
- API graduation criteria clear
- Version skew strategy documented
Acceptance Criteria
- PR opened in openshift/api with api-review label
- All required API approvers have reviewed
- All feedback addressed and resolved
- LGTM obtained from @deads2k and @JoelSpeed
- Enhancement updated with approval details
- API review meeting notes captured (if applicable)
- duplicates
-
CNTRLPLANE-1745 duplicate: API review and approval process
-
- Closed
-
- links to