Uploaded image for project: 'Red Hat OpenShift Control Planes'
  1. Red Hat OpenShift Control Planes
  2. CNTRLPLANE-1681

Update mvdan.cc/unparam (Go linter tool dependency)

XMLWordPrintable

    • None
    • False
    • Hide

      None

      Show
      None
    • False
    • None

      Overview

      Update the unparam linter dependency from digest 8a5130c to 0df0534.

      Dependency Information

      • Package: mvdan.cc/unparam
      • Type: Indirect dependency (pulled in by golangci-lint)
      • Direct parent: github.com/golangci/golangci-lint v1.64.8
      • Old version: v0.0.0-20240528143540-8a5130ca722f
      • New version: v0.0.0-20250109145734-0df05343cb22
      • Location: hack/tools/go.mod

      Usage in HyperShift

      This is an indirect dependency used for code quality checks:

      • Primary usage: Static analysis linter for detecting unused function parameters
      • Integrated via: golangci-lint (development/CI tooling)
      • Purpose: Code quality enforcement during development and CI builds
      • Impact: Development tooling only, not included in runtime binaries

      Changes in Update

      This is a digest update for the unparam linter tool, likely containing bug fixes and improvements to parameter usage detection.

      How to Test

      To verify this update works correctly:

        1. Build the linter tool:
             make TOOLS_BIN_DIR=./bin/tools golangci-lint
             

      2. Run the linter:

         make lint
         

      This will run golangci-lint on both the main codebase and the api/ subdirectory.

      3. Verify the linter runs successfully:

      • The command should complete without errors
      • Any code quality issues found should be legitimate (not tool bugs)
      • The unparam linter should detect unused parameters if any exist

      4. Optional - Run with auto-fix:

         make lint-fix
         

      This tests that the linter's auto-fix functionality works correctly.

      Expected behavior: The linter should run successfully and produce consistent results with the previous version.

              Unassigned Unassigned
              asegurap1@redhat.com Antoni Segura Puimedon
              None
              None
              None
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: