Details
-
Bug
-
Resolution: Done
-
Undefined
-
None
-
None
-
None
-
False
-
-
False
-
UnsupportedConfigOverrides now appends user provided arguments to that of the default container arguments instead of replacing them.
-
0
Description
By default, the controller has some default args:
$ oc -n openshift-cert-manager get deploy/cert-manager -oyaml | yq -e '.spec.template.spec.containers[0].args'
- --v=2
- --cluster-resource-namespace=$(POD_NAMESPACE)
- --leader-election-namespace=kube-system
However, when one wants to add extraArgs, it just replaces it instead of adding it:
$ oc patch certmanager.operator/cluster --type=merge -p '{"spec":{"unsupportedConfigOverrides":{"controller":{"args":["--dns01-recursive-nameservers=1.1.1.1:53","--dns01-recursive-nameservers-only"]}}}}' certmanager.operator.openshift.io/cluster patched $ oc -n openshift-cert-manager get deploy/cert-manager -oyaml | yq -e '.spec.template.spec.containers[0].args' - --dns01-recursive-nameservers=1.1.1.1:53 - --dns01-recursive-nameservers-only
That seems to be different than what originally cert-manager's helm chart installation option:
--set 'extraArgs={--dns01-recursive-nameservers-only,--dns01-recursive-nameservers=8.8.8.8:53\,1.1.1.1:53}'
The helm chart option behavior is adding, not replacing.
Should unsupportedConfigOverrides.controller.args mimic what the extraArgs does?
Thanks.
-Alan
