Uploaded image for project: 'Cert Manager support for Red Hat OpenShift'
  1. Cert Manager support for Red Hat OpenShift
  2. CM-23

unsupportedConfigOverrides replaces args instead of append/add

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Undefined Undefined
    • cert-manager-1.10.2
    • None
    • None
    • None
    • False
    • Hide

      None

      Show
      None
    • False
    • UnsupportedConfigOverrides now appends user provided arguments to that of the default container arguments instead of replacing them.
    • 0

      By default, the controller has some default args:

      $ oc -n openshift-cert-manager get deploy/cert-manager -oyaml | yq -e '.spec.template.spec.containers[0].args'
      - --v=2
      - --cluster-resource-namespace=$(POD_NAMESPACE)
      - --leader-election-namespace=kube-system
      

      However, when one wants to add extraArgs, it just replaces it instead of adding it:

      $ oc patch certmanager.operator/cluster --type=merge -p '{"spec":{"unsupportedConfigOverrides":{"controller":{"args":["--dns01-recursive-nameservers=1.1.1.1:53","--dns01-recursive-nameservers-only"]}}}}'
      certmanager.operator.openshift.io/cluster patched
      
      $ oc -n openshift-cert-manager get deploy/cert-manager -oyaml | yq -e '.spec.template.spec.containers[0].args'
      - --dns01-recursive-nameservers=1.1.1.1:53
      - --dns01-recursive-nameservers-only
      

      That seems to be different than what originally cert-manager's helm chart installation option:

      --set 'extraArgs={--dns01-recursive-nameservers-only,--dns01-recursive-nameservers=8.8.8.8:53\,1.1.1.1:53}'
      

      The helm chart option behavior is adding, not replacing.

      Should unsupportedConfigOverrides.controller.args mimic what the extraArgs does?

      Thanks.

      -Alan

            thn@redhat.com Thejas N (Inactive)
            rhn-support-alchan Alan Chan (Inactive)
            Xingxing Xia Xingxing Xia
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: